[issue16784] Int tests enhancement and refactoring

[Irit Katriel]

Change by Irit Katriel :


--
resolution:  -> fixed
stage: needs patch -> resolved
status: pending -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16784] Int tests enhancement and refactoring

[Irit Katriel]

Irit Katriel  added the comment:

It seems that all dependencies are complete, so if nobody will object I will 
close this too.

--
nosy: +iritkatriel
status: open -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16784] Int tests enhancement and refactoring

[Mark Lawrence]

Change by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16784] Int tests enhancement and refactoring

[Mark Lawrence]

Mark Lawrence added the comment:

is there anything left to do here?

--
nosy: +BreamoreBoy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16784
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16784] Int tests enhancement and refactoring

[Chris Jerdonek]

Chris Jerdonek added the comment:

Another task: backport the tests for current behavior added under issue 16772 
(e.g. test_int_base_limits() tests).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16784
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16784] Int tests enhancement and refactoring

[Chris Jerdonek]

Chris Jerdonek added the comment:

Improvement of int/long tests should also be reflected in the Tests section of 
Misc/NEWS.  An entry wasn't added in issue 16045.  For linking purposes, this 
issue number would probably be the best to use for such an entry.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16784
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16784] Int tests enhancement and refactoring

[Serhiy Storchaka]

Changes by Serhiy Storchaka storch...@gmail.com:


--
dependencies: +Mark small ints test as CPython-only

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16784
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16784] Int tests enhancement and refactoring

[Serhiy Storchaka]

Changes by Serhiy Storchaka storch...@gmail.com:


--
dependencies: +Get rid of deprecated assertEquals etc in tests

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16784
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16784] Int tests enhancement and refactoring

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

Int tests should be synchronized between different Python versions. Tests for 
int and long should be synchronized in 2.7. Common code for int and long tests 
should be shared in 2.7. CPython tests (i.e. small int identity) should be 
extracted to separated methods. Tests should be resorted by tested feature. 
Deprecated assertEquals should be replaced to assertEqual. And may be more.

--
assignee: serhiy.storchaka
components: Tests
messages: 178197
nosy: serhiy.storchaka
priority: normal
severity: normal
stage: needs patch
status: open
title: Int tests enhancement and refactoring
type: enhancement
versions: Python 2.7, Python 3.2, Python 3.3, Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16784
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16784] Int tests enhancement and refactoring

[Serhiy Storchaka]

Changes by Serhiy Storchaka storch...@gmail.com:


--
dependencies: +Fix int(base=X), int() accepts float number base
nosy: +chris.jerdonek

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16784
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16784] Int tests enhancement and refactoring

[Chris Jerdonek]

Chris Jerdonek added the comment:

Other things that should be done include porting the more comprehensive tests 
in a recent changeset from 2.7 to 3.x and refactoring the try-except of one of 
the tests as necessary (see the Rietveld comments of issue 16761 for details on 
both).

The various issues in this comment and above should probably be broken into 
multiple patches.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16784
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16784] Int tests enhancement and refactoring

[Chris Jerdonek]

Chris Jerdonek added the comment:

I created issue 16790 to allow the sharing of tests between test_int and 
test_long in 2.7.  I don't think issue 16761 and issue 16772 should be 
prerequisites to this issue though because both issues could benefit from issue 
16790 being committed first (since both issues may involve adding tests to 
test_int and test_long).

Also, I don't necessarily think that *all* tests should be shared between 
test_int and test_long because that refactoring may be too invasive, but 
certainly the new ones we are considering adding.

--
dependencies: +provide ability to share tests between int and long tests

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16784
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16784] Int tests enhancement and refactoring

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

A large part of IntTestCases.test_basic() and LongTest.test_long() can be 
shared, as a number of smaller tests.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16784
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16784] Int tests enhancement and refactoring

[Chris Jerdonek]

Chris Jerdonek added the comment:

Agreed.  I just didn't want it to be a requirement of beginning shared tests in 
case anyone objects to refactoring existing tests in 2.7 -- as opposed to using 
it for the addition of new tests.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16784
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com