Serhiy Storchaka added the comment:
Since there are no other reports about 8.6 I close this issue.
--
resolution: - fixed
stage: commit review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 6b841e1ee3b8 by Serhiy Storchaka in branch '3.3':
Issue #16809: Tkinter's splitlist() and split() methods now accept Tcl_Obj
http://hg.python.org/cpython/rev/6b841e1ee3b8
New changeset 85285e6e28f4 by Serhiy Storchaka in branch 'default':
Issue
Roundup Robot added the comment:
New changeset 516b0cd87a90 by Serhiy Storchaka in branch '3.3':
Issue #16809: Fixed some tkinter incompabilities with Tcl/Tk 8.6.
http://hg.python.org/cpython/rev/516b0cd87a90
New changeset 5b5ef012cd4e by Serhiy Storchaka in branch 'default':
Issue #16809:
Serhiy Storchaka added the comment:
Thank you alejandro. Fixed.
I'm afraid this is not all problems with 8.6 and so left this issue open.
--
priority: high - critical
stage: needs patch - commit review
versions: -Python 3.2
___
Python tracker
alejandro autalan added the comment:
Hello.
I tried 'tkinter_split.patch' patch against 3.3.2, but a fix for grid_info
function is also needed.
#test.py
import tkinter as tk
root = tk.Tk()
b = tk.Button(root, text='Button')
b.grid()
print(b.grid_info())
root.mainloop()
Here's is the
Arfrever Frehtes Taifersar Arahesis added the comment:
Please commit the full patch in all active branches.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16809
___
Changes by Mike Gilbert floppymas...@gmail.com:
--
nosy: +floppymaster
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16809
___
___
Serhiy Storchaka added the comment:
Yes, I considered this option. A sure way to get rid of this and future changes
in Tcl types, is get rid of Tcl_Obj at all and always return strings (if it is
not a number or list). The drawback of this method is that occurs unnecessary
conversion between
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file29477/tkinter_splitlist.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16809
___
Serhiy Storchaka added the comment:
Here are a patch which quickly switch off Tcl_Obj.
--
Added file: http://bugs.python.org/file30428/tkinter_no_tcl_obj.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16809
Serhiy Storchaka added the comment:
And here is a patch which allows Tk.splitline() and Tk.split() to work with
Tcl_Obj. It also includes some other minor fixes to support Tcl 8.6. The patch
includes a fix for issue18101.
--
Added file:
Roger Serwy added the comment:
The problem I'm encountering is that tk.splitlist() is now being given a
Tcl_Obj instead of a str type. Since everything is Tcl is a string,
explicitly casting a Tcl_Obj to a string seems reasonable. Attached is some
proof-of-concept code to work around the
Roger Serwy added the comment:
Serhiy, I applied your patch but I still get the same error.
From what I have found so far, the FromObj function in Modules/_tkinter.c
relies on cached values for different Tcl_ObjType, as given in the TkappObject
struct. From the comment:
/* We cannot
Serhiy Storchaka added the comment:
Here is a patch which add support of Tcl_Obj to tkinter's splitlist(). This not
only fixes some incompatibility with Tk 8.6, but can fix some issues with older
Tk versions (see for example issue17397).
--
keywords: +patch
nosy: +gpolo
stage: -
Changes by Martin Panter vadmium...@gmail.com:
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16809
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
I don't install Tcl/Tk 8.6 yet, but looks as pack info call returns a new
type of Tcl data (perhaps DictType) which doesn't detected in FromObj().
--
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
The simplest fix probably is just wrap self.tk.call() with str() (I have not
tested it yet). However the problem is more serious (tkinter doesn't support
fully even 8.5 and subtle bugs are possible) and I'll spend some more time on
its research.
--
Roger Serwy added the comment:
In Objects/unicodeobject.c in PyUnicode_FromObject, the call to
PyUnicode_CheckExact fails when using 8.6.0 but works with 8.5.13.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16809
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16809
___
___
New submission from Roger Serwy:
I am running Arch Linux with the latest Tcl/Tk 8.6.0 build with Python 2.7.3
and 3.3.0, and the latest 3.4.0a0 build from the repository.
Running the attached script fails when calling pack_info(). Here's is the
script's output:
8.6
Traceback (most recent
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16809
___
21 matches
Mail list logo
