Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16840
___
Roundup Robot added the comment:
New changeset 4bf210f59ac6 by Serhiy Storchaka in branch '2.7':
Issue #16840: Skip bignum tests on minor releases where they are not supported.
https://hg.python.org/cpython/rev/4bf210f59ac6
New changeset 97519d85b5c8 by Serhiy Storchaka in branch '3.4':
Issue
Roundup Robot added the comment:
New changeset 5116916e4f7f by Serhiy Storchaka in branch '2.7':
Issue #16840. Turn off bignum support in tkinter with with Tcl earlier than
8.5.8
https://hg.python.org/cpython/rev/5116916e4f7f
--
___
Python tracker
Serhiy Storchaka added the comment:
This didn't help. Actually we should turn on bignum support only since 8.5.8,
because tclTomMath.h was broken before. But this is not related, because
tclTomMath.h is not found itself on this buildbot.
--
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: fixed -
stage: resolved - patch review
versions: +Python 2.7, Python 3.4
Added file: http://bugs.python.org/file39158/tkinter_hexversion.patch
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
Ah, we should also test full version of 8.6, because bignums was not supported
in earlier alphas and betas (if I remember correctly, this buildbot uses beta
version of 8.6).
TK_VERSION_HEX packs fields in wrong order, not suitable for comparing of
Roundup Robot added the comment:
New changeset 8ab077c22fbf by Serhiy Storchaka in branch '2.7':
Issue #16840: Turn on support of bignums only in final release of Tcl 8.5.
https://hg.python.org/cpython/rev/8ab077c22fbf
New changeset 7f1622478d17 by Serhiy Storchaka in branch '3.4':
Issue
Serhiy Storchaka added the comment:
There is at least one buildbot that now fails to build _tkinter.
http://buildbot.python.org/all/builders/x86%20FreeBSD%206.4%202.7/builds/2457/steps/test/logs/stdio
building '_tkinter' extension
gcc -pthread -fPIC -fno-strict-aliasing -g -O2 -g -O0 -Wall
STINNER Victor added the comment:
test_expr_bignum() should tolerate the long type:
http://buildbot.python.org/all/builders/x86%20Tiger%202.7/builds/3007/steps/test/logs/stdio
==
FAIL: test_expr_bignum (test.test_tcl.TclTest)
Serhiy Storchaka added the comment:
It is important that the result is an int at least for small ints. So I prefer
to keep limited test.
-self.assertIsInstance(result, type(int(result)))
+if abs(result) 2**31:
+self.assertIsInstance(result, int)
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16840
___
Roundup Robot added the comment:
New changeset 42a6449e577c by Serhiy Storchaka in branch '2.7':
Issue #16840: Tkinter now supports 64-bit integers added in Tcl 8.4 and
https://hg.python.org/cpython/rev/42a6449e577c
New changeset a6f4d8fa7ab8 by Serhiy Storchaka in branch '3.4':
Issue #16840:
Roundup Robot added the comment:
New changeset 9905fb0b5885 by Serhiy Storchaka in branch '2.7':
Issue #16840: Fixed test_tcl for Tcl 8.5.
https://hg.python.org/cpython/rev/9905fb0b5885
New changeset 1d2444273b3d by Serhiy Storchaka in branch '3.4':
Issue #16840: Fixed test_tcl for Tcl 8.5.
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file28551/tkinter_bignum.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16840
___
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file31420/tkinter_bignum_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16840
___
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file35280/tkinter_bignum_3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16840
___
Serhiy Storchaka added the comment:
Updated patch now supports wideInt if PY_LONG_LONG is not defined or is not
equal to Tcl_WideInt. getint() also now supports big integers (currently it
returns ambiguous result for values outside the range of C signed int).
As far as this issue causes
Benjamin Peterson added the comment:
I'm all for fixing random test failures.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16840
___
___
Benjamin Peterson added the comment:
It's up to you. Since 2.7 is so long lived, we've had to gradually alter
supported library versions (e.g. for bsddb).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16840
Serhiy Storchaka added the comment:
But there is a risk to break Python builds with old Tcl/Tk. We dropped support
of Tcl/Tk older than 8.4 in 3.5, but theoretically 2.7 should work with older
versions. It was not tested for years, we have no build bots with 8.3, and I
manually test Python
Serhiy Storchaka added the comment:
Here is test failure related to this issue:
http://buildbot.python.org/all/builders/AMD64%20Windows8%202.7/builds/156/steps/test/logs/stdio
test test_tk failed -- Traceback (most recent call last):
File
Serhiy Storchaka added the comment:
Patch synchronized with tip and fixed support of Tcl 8.5.
--
Added file: http://bugs.python.org/file35280/tkinter_bignum_3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16840
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16840
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
Patch updated.
--
Added file: http://bugs.python.org/file31420/tkinter_bignum_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16840
___
Serhiy Storchaka added the comment:
I reclassify this as enhancement until the real bug is not found.
--
type: behavior - enhancement
versions: -Python 2.7, Python 3.2, Python 3.3
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
Here is a patch which adds support of wideInt and bignum Tcl types.
--
assignee: serhiy.storchaka -
keywords: +patch
stage: needs patch - patch review
Added file: http://bugs.python.org/file28551/tkinter_bignum.patch
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16840
___
___
New submission from Serhiy Storchaka:
A long time Tcl got support first 64-bit integers, and then arbitrary size
integers. Python also supports arbitrary size integers. However Tkinter
supports only C long integers. For example, on 32-bit platform:
import tkinter
t = tkinter.Tk()
28 matches
Mail list logo