[issue16942] urllib still doesn't support persistent connections
Senthil Kumaran added the comment: Agree with Demian Brecht. This issue is being closed in when two issues cover the requirements discussed here. * issue# 16901 - For Enhancing FileCookieJar * issue# 9740 - For supporting persistant HTTP 1.1 connections. (:-( on me) -- nosy: +orsenthil resolution: - duplicate stage: needs patch - committed/rejected status: open - closed superseder: - In http.cookiejar.FileCookieJar() the .load() and .revert() methods don't work ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16942 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16942] urllib still doesn't support persistent connections
Demian Brecht added the comment: Just noticed there was a typo in the link in my previous post. It should be directing to issue# 16901. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16942 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16942] urllib still doesn't support persistent connections
Demian Brecht added the comment: http://bugs.python.org/issue1690 seems to be a duplicate of this one (at least the initial report). 16901 (imho) is documented more clearly than this one, so can this one be closed as duplicate? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16942 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16942] urllib still doesn't support persistent connections
Terry J. Reedy added the comment: +class FileCookieJar(CookieJar, metaclass=ABCMeta): +Abstract Base Class for any file-based CookieJar. Is it just me or is it a bit strange to derive an abstract base class from a concrete class? Is CookieJar meant to be directly used? +with open(self.filename) as f: +magic = f.readline() +if not self.magic_re.search(magic): +f.close() +raise LoadError( +%r does not look like a Netscape format cookies f.close() seems not needed as doing that in __exit__ as a major point of with open... statements. -- nosy: +terry.reedy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16942 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16942] urllib still doesn't support persistent connections
Changes by Demian Brecht demianbre...@gmail.com: -- nosy: +dbrecht ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16942 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16942] urllib still doesn't support persistent connections
Demian Brecht added the comment: I've changed FileCookieJar to use the ABCMeta metaclass and updated the concrete implementations. If this patch looks sufficient, I'll make an update to the docs as well. -- keywords: +patch Added file: http://bugs.python.org/file29215/cookiejar_16942.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16942 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16942] urllib still doesn't support persistent connections
Changes by Ramchandra Apte maniandra...@gmail.com: -- title: seriously? urllib still doesn't support persistent connections? - urllib still doesn't support persistent connections ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16942 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16942] urllib still doesn't support persistent connections
R. David Murray added the comment: Please open a separate issue for your enhancement request in your second message (assuming there isn't already one open). I'm not sure what your third message is about, but it also sounds off topic for your original bug report. For the FileCookieJar issue, I agree that the documentation is unclear. However, it is perfectly reasonable to have a documented base class that is an Abstract Base Class, and there is no reason for us to invent our own unique cookie file format just to make FileCookieJar work by itself. ABCs didn't exist when FileCookieJar was implemented, so it should be turned in to one for 3.4 (it might break working code, so we shouldn't do that for bug fix releases). That way you would get a useful error when you try to instantiate it, rather than when you try to use it. And the docs should document it as being a base-class-only for all active releases. -- assignee: - docs@python components: +Documentation, Library (Lib) nosy: +docs@python, r.david.murray stage: - needs patch type: enhancement - behavior versions: +Python 3.4 -Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16942 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
