[issue16993] shutil.which() should preserve path case

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thank you, Stefan. This relates to issue16957.

--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16993] shutil.which() should preserve path case

[Stefan Krah]

Stefan Krah added the comment:

Serhiy, test_pathext_checking still fails on many Windows buildbots:

http://buildbot.python.org/all/waterfall?category=3.x.stable&category=3.x.unstable

--
nosy: +skrah
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16993] shutil.which() should preserve path case

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I chose the first simplest variant.

--
resolution:  -> fixed
stage:  -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16993] shutil.which() should preserve path case

[Roundup Robot]

Roundup Robot added the comment:

New changeset 28282e4e9d04 by Serhiy Storchaka in branch '3.3':
Fix shutil.which() test for issue #16993.
http://hg.python.org/cpython/rev/28282e4e9d04

New changeset e8f40d4f497c by Serhiy Storchaka in branch 'default':
Fix shutil.which() test for issue #16993.
http://hg.python.org/cpython/rev/e8f40d4f497c

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16993] shutil.which() should preserve path case

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Test broken on Windows because PATHEXT contains uppercased extension ".EXT".

Proposed solutions:

1. Fix the test: expect uppercased extension, or do case-insensitive extension 
comparison, or get extension from PATHEXT.
2. Rollback the part of previous changes which preserve case of extensions from 
PATHEXT and always lowercase them.
3. Rollback the changes overall.
4. Use not used for now ntpath._getfinalpathname() to get a real file name (it 
resolves symlinks, though).

--
nosy: +pitrou
resolution: fixed -> 
stage: committed/rejected -> 
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16993] shutil.which() should preserve path case

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16993] shutil.which() should preserve path case

[Roundup Robot]

Roundup Robot added the comment:

New changeset d2db601a53b3 by Serhiy Storchaka in branch '3.3':
Issue #16993: shutil.which() now preserves the case of the path and extension
http://hg.python.org/cpython/rev/d2db601a53b3

New changeset 5faae2bdf1e0 by Serhiy Storchaka in branch 'default':
Issue #16993: shutil.which() now preserves the case of the path and extension
http://hg.python.org/cpython/rev/5faae2bdf1e0

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16993] shutil.which() should preserve path case

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
assignee:  -> serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16993] shutil.which() should preserve path case

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Oh, sorry. Here is a patch.

--
keywords: +patch
Added file: http://bugs.python.org/file28781/shutil_which_normcase.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16993] shutil.which() should preserve path case

[Ramchandra Apte]

Ramchandra Apte added the comment:

Somehow the patch is not showing for me.

--
nosy: +ramchandra.apte

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16993] shutil.which() should preserve path case

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
components: +Library (Lib), Windows
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16993] shutil.which() should preserve path case

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

Now which lowercase found directory name and extension on Windows.

>>> shutil.which("python")
'c:\\python33\\python.exe'

Proposed patch preserve case.

>>> shutil.which("python")
'C:\\Python33\\python.exe'

Please test this on Windows.

--
messages: 180181
nosy: hynek, serhiy.storchaka, tarek
priority: normal
severity: normal
status: open
title: shutil.which() should preserve path case
type: behavior
versions: Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com