[issue1703178] link_objects in setup.cfg crashes build

[Roundup Robot]

Roundup Robot added the comment:

New changeset 520ca3652422 by Benjamin Peterson in branch '2.7':
build_ext: correctly parse the link_objects user option (closes #1703178)
https://hg.python.org/cpython/rev/520ca3652422

New changeset b2f0a31fa441 by Benjamin Peterson in branch '3.5':
build_ext: correctly parse the link_objects user option (closes #1703178)
https://hg.python.org/cpython/rev/b2f0a31fa441

New changeset eac20127d51e by Benjamin Peterson in branch '3.6':
merge 3.5 (#1703178)
https://hg.python.org/cpython/rev/eac20127d51e

New changeset 9485165435e4 by Benjamin Peterson in branch 'default':
merge 3.6 (#1703178)
https://hg.python.org/cpython/rev/9485165435e4

--
nosy: +python-dev
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1703178] link_objects in setup.cfg crashes build

[R. David Murray]

R. David Murray added the comment:

This issue is marked for 2.7, 3.4, and 3.5, but the test runs only on 3.5.

--
assignee:  -> eric.araujo
nosy: +r.david.murray
stage: commit review -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1703178] link_objects in setup.cfg crashes build

[Berker Peksag]

Changes by Berker Peksag :


--
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1703178] link_objects in setup.cfg crashes build

[Valerie Lambert]

Valerie Lambert added the comment:

Fixed the typo and reuploaded. Thanks for spotting that!

--
Added file: http://bugs.python.org/file37403/build_ext_v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1703178] link_objects in setup.cfg crashes build

[Bruno Cauet]

Bruno Cauet added the comment:

There's a small typo in the comments:

+# make sure cmd.link_objects is turned into a list
+# is it's a string

Should be:

+# make sure cmd.link_objects is turned into a list
+# if it's a string

--
nosy: +bru

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1703178] link_objects in setup.cfg crashes build

[Éric Araujo]

Éric Araujo added the comment:

Thanks for the patch.  It looks good to me.

--
assignee: eric.araujo -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1703178] link_objects in setup.cfg crashes build

[Terry J. Reedy]

Terry J. Reedy added the comment:

Donald, can you look at this one-line patch?  Éric has not responded.

--
nosy: +dstufft, terry.reedy -tarek

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1703178] link_objects in setup.cfg crashes build

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
nosy:  -terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1703178] link_objects in setup.cfg crashes build

[Terry J. Reedy]

Terry J. Reedy added the comment:

Valerie, I cannot review this.  If Éric does not respond in a month or two, you 
might enquire on python-dev or core-mentorship lists.

--
stage: test needed -> patch review
versions: +Python 3.5 -Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1703178] link_objects in setup.cfg crashes build

[Valerie Lambert]

Valerie Lambert added the comment:

Here is a simple one-line-fix patch with a test. 

Except for the libraries option, other options separate using ':'. The 
documentation didn't seem to say much, so I wasn't sure if link_objects should 
be consistent with that or if it should follow libraries's example and instead 
allow spaces and commas for separation. This patch uses ensure_string_list as 
suggested, but let me know if using .split(os.pathsep) is a better idea.

--
keywords: +patch
nosy: +lambertv
Added file: http://bugs.python.org/file36861/build_ext.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1703178] link_objects in setup.cfg crashes build

[Éric Araujo]

Changes by Éric Araujo :


--
components:  -Distutils2
versions: +Python 3.4 -3rd party, Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1703178] link_objects in setup.cfg crashes build

[Éric Araujo]

Éric Araujo  added the comment:

The code in build_ext is missing a few ensure_string_list calls; it is a method 
that converts a string (from the setup.cfg file or command line) into a list, 
or if the attribute is already a list (if it was given in setup.py) then leave 
it alone.  Recently I fixed the same bug with the build_ext --libraries option 
(#1326113), so it’s easy to make a patch with the same kind of tests and the 
code fix.

--
assignee: tarek -> eric.araujo
components: +Distutils2 -Build
keywords: +easy
nosy: +alexis, eric.araujo
status: pending -> open
versions: +3rd party, Python 3.2, Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1703178] link_objects in setup.cfg crashes build

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Is there still a problem with 2.7 or 3.x?

--
nosy: +terry.reedy
status: open -> pending
versions: +Python 2.7 -Python 2.6, Python 3.0

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1703178] link_objects in setup.cfg crashes build

[Daniel Diniz]

Changes by Daniel Diniz :


--
assignee:  -> tarek
components: +Build, Distutils -None
nosy: +tarek
stage:  -> test needed
type:  -> behavior
versions: +Python 2.6, Python 3.0 -Python 2.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com