Brett Cannon added the comment:
> Has there been any resolution regarding `sortTestMethodsUsing`?
My suspicion is if the docs don't suggest there's something else then nothing
has been changed.
--
___
Python tracker
Nils Kattenbeck added the comment:
Has there been any resolution regarding `sortTestMethodsUsing`? See
https://bugs.python.org/msg77261
I spend a decent time and read the documentation thrice before realizing it
received an old-style compare function. Brett's proposal for a new attribute
Roundup Robot added the comment:
New changeset 64e004737837 by R David Murray in branch '3.3':
#18324: set_payload now correctly handles binary input.
http://hg.python.org/cpython/rev/64e004737837
--
nosy: +python-dev
___
Python tracker
Georg Brandl ge...@python.org added the comment:
Documentation updated in r70863.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1717
___
Changes by Benjamin Peterson benja...@python.org:
--
priority: release blocker - normal
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1717
___
___
Anthony Tuininga anthony.tuini...@gmail.com added the comment:
Removing cmp() breaks distutils. I get the following exception, for
example using the just released version 3.0.1:
Traceback (most recent call last):
File setup.py, line 318, in module
classifiers = classifiers)
File
Changes by Georg Brandl ge...@python.org:
--
priority: normal - release blocker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1717
___
___
Benjamin Peterson benja...@python.org added the comment:
Fixed in r69682.
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1717
___
___
Python-bugs-list
Mark Dickinson dicki...@gmail.com added the comment:
Darn. That's really very annoying. Apologies for missing this one.
Thanks for the quick fix, Benjamin.
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1717
Mark Dickinson dicki...@gmail.com added the comment:
Deprecation warning for types that implement tp_compare but not
tp_richcompare added in r69431, r69432.
Just the doc fixes in Doc/extending/newtypes.rst left. Assigning to Georg
and reducing priority.
--
assignee: - georg.brandl
Mark Dickinson dicki...@gmail.com added the comment:
All relevant changes from the py3k-issue1717 branch have now been merged into
the py3k
branch (and from there into the 3.0 maintenance branch), in a series of
revisions.
Here they are, listed in py3k/release30-maint pairs:
r69188,
Mark Dickinson dicki...@gmail.com added the comment:
Thanks for the review, Antoine.
Stage 2 applied to py3k in r69181, merged to 3.0 in r69182.
cmp, PyObject_Cmp and PyObject_Compare removed in r69184 (py3k) and r69185
(release30-maint).
There's still the rename of the tp_compare slot to
Mark Dickinson dicki...@gmail.com added the comment:
Here's stage 2: remove uses of tp_compare from Objects and Modules, and
replace uses of PyObject_Compare with PyObject_RichCompareBool.
PyObject_Compare, cmp and friends still haven't been removed at this
stage.
In detail:
- for cell
Antoine Pitrou pit...@free.fr added the comment:
I haven't stared very closely but it looks ok.
(spanish armada might be replaced with spanish inquisition, though)
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1717
Mark Dickinson dicki...@gmail.com added the comment:
I'm not going to get more time to work on this before
the weekend, so if anyone else wants to take over please
feel free.
Still to do for stage 2: cell objects and slot
wrapper objects need to have tp_richcompare
implemented, to replace the
Raymond Hettinger rhettin...@users.sourceforge.net added the comment:
For 3.0, are you going to keep tp_compare slot in existence and just
assert that it is NULL? Then in 3.1, remove the slot entirely?
___
Python tracker rep...@bugs.python.org
Mark Dickinson dicki...@gmail.com added the comment:
If I understand Christian's plan correctly, it was to:
(1) raise TypeError for non-NULL tp_compare, and
(2) rename tp_compare to tp_reserved (with type void *).
and both of these would happen with 3.0.1, so no difference between
3.0.1 and
Benjamin Peterson benja...@python.org added the comment:
Actually, I would like to repurpose tp_compare as tp_bytes for the
__bytes__ method.
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1717
___
Brett Cannon br...@python.org added the comment:
On Thu, Jan 29, 2009 at 07:30, Benjamin Peterson rep...@bugs.python.org wrote:
Benjamin Peterson benja...@python.org added the comment:
Actually, I would like to repurpose tp_compare as tp_bytes for the
__bytes__ method.
Repurposing would be
Benjamin Peterson benja...@python.org added the comment:
On Thu, Jan 29, 2009 at 2:39 PM, Brett Cannon rep...@bugs.python.org wrote:
Brett Cannon br...@python.org added the comment:
On Thu, Jan 29, 2009 at 07:30, Benjamin Peterson rep...@bugs.python.org
wrote:
Benjamin Peterson
Brett Cannon br...@python.org added the comment:
On Thu, Jan 29, 2009 at 07:30, Benjamin Peterson rep...@bugs.python.org
wrote:
Benjamin Peterson benja...@python.org added the comment:
Actually, I would like to repurpose tp_compare as tp_bytes for the
__bytes__ method.
Repurposing
Mark Dickinson dicki...@gmail.com added the comment:
Can anyone who uses tkinter give me some advice? Does PyTclObject in
_tkinter.c need to have its tp_richcompare method implemented? And if so,
how do I go about testing the implementation? It seems that PyTclObjects
aren't directly
Guilherme Polo ggp...@gmail.com added the comment:
Mark,
I'm not a very huge user of tkinter, but I can tell you it would be
tricky to try getting a PyTclObject. It needs to be exposed if you want
to test it without relying on Tcl, but, to me they are just a
temporary object that serves to
Mark Dickinson dicki...@gmail.com added the comment:
Thanks, Guilherme.
For this reason I would actually prefer to them not be comparable.
That's fine with me, so long as we can be sure that there's no existing
code that depends on them being comparable. I can't figure out whether
there's
Mark Dickinson dicki...@gmail.com added the comment:
Stage 1 committed in r69025 (py3k) and r69026 (release30-maint).
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1717
___
Mark Dickinson dicki...@gmail.com added the comment:
I'm wondering how to move forward with this issue. Might it make sense to
break the current monster patch into a series of more-easily reviewed
patches? I was thinking of something like:
- patch 1 (Python code): remove all uses of cmp
Antoine Pitrou pit...@free.fr added the comment:
Quick comments on your patch:
- two files have unwanted modifications on non-ASCII characters
(Lib/heapq.py and Lib/sqlite3/test/hooks.py)
- you haven't renamed __cmp__ to _cmp in Lib/xmlrpc/client.py:
deliberate?
- in Lib/heapq.py, there's a
Mark Dickinson dicki...@gmail.com added the comment:
Thanks, Antoine. Here's a new patch.
- two files have unwanted modifications on non-ASCII characters
(Lib/heapq.py and Lib/sqlite3/test/hooks.py)
Fixed, I think. Could you double check?
- you haven't renamed __cmp__ to _cmp in
Antoine Pitrou pit...@free.fr added the comment:
Fixed, I think. Could you double check?
It's ok!
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1717
___
Changes by Martin v. Löwis mar...@v.loewis.de:
--
title: Get rid of more refercenes to __cmp__ - Get rid of more references to
__cmp__
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1717
___
30 matches
Mail list logo
