[issue17249] reap threads in test_capi

[Roundup Robot]

Roundup Robot added the comment:

New changeset 041d0f68c67d by Ezio Melotti in branch '2.7':
#17249: check for the availability of the thread module.
http://hg.python.org/cpython/rev/041d0f68c67d

New changeset 01fdf24c9d75 by Ezio Melotti in branch '3.2':
#17249: check for the availability of the thread module.
http://hg.python.org/cpython/rev/01fdf24c9d75

New changeset eb9edac39751 by Ezio Melotti in branch '3.3':
#17249: null merge.
http://hg.python.org/cpython/rev/eb9edac39751

New changeset cb46ccdc226a by Ezio Melotti in branch 'default':
#17249: null merge.
http://hg.python.org/cpython/rev/cb46ccdc226a

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17249] reap threads in test_capi

[Ezio Melotti]

Ezio Melotti added the comment:

Fixed, thanks for the reviews!

--
assignee:  -> ezio.melotti
resolution:  -> fixed
stage: patch review -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17249] reap threads in test_capi

[Roundup Robot]

Roundup Robot added the comment:

New changeset c6ca87fbea39 by Ezio Melotti in branch '2.7':
#17249: convert a test in test_capi to use unittest and reap threads.
http://hg.python.org/cpython/rev/c6ca87fbea39

New changeset 329732a1572f by Ezio Melotti in branch '3.2':
#17249: convert a test in test_capi to use unittest and reap threads.
http://hg.python.org/cpython/rev/329732a1572f

New changeset 81f98372f893 by Ezio Melotti in branch '3.3':
#17249: merge with 3.2.
http://hg.python.org/cpython/rev/81f98372f893

New changeset f716a178b4e1 by Ezio Melotti in branch 'default':
#17249: merge with 3.3.
http://hg.python.org/cpython/rev/f716a178b4e1

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17249] reap threads in test_capi

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

This test was introduced in a4154dd5939a.

--
nosy: +mhammond

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17249] reap threads in test_capi

[R. David Murray]

R. David Murray added the comment:

Looks good to to me.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17249] reap threads in test_capi

[Ezio Melotti]

Ezio Melotti added the comment:

The attached patch converts the function in a real test, using proper skips and 
assert methods.

--
components: +Library (Lib) -Tests
Added file: http://bugs.python.org/file29159/issue17249.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17249] reap threads in test_capi

[R. David Murray]

R. David Murray added the comment:

Looks like a straightforward translation to me.  There's no obvious reason not 
to move it to being a real test, which means it would sure be nice if we knew 
why it was left in test_main.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17249] reap threads in test_capi

[Ezio Melotti]

New submission from Ezio Melotti:

The attached patch fixes the following warning:

$ ./python -m test test_capi
[1/1] test_capi
Warning -- threading._dangling was modified by test_capi
1 test altered the execution environment:
test_capi

This test was introduced in f7993dc6bf26, and it seems to predate unittest.  
Maybe it should be moved outside test_main while we are at it.

--
components: Tests
files: reap_threads.diff
keywords: patch
messages: 182463
nosy: ezio.melotti, pitrou, serhiy.storchaka
priority: normal
severity: normal
stage: patch review
status: open
title: reap threads in test_capi
type: behavior
versions: Python 2.7, Python 3.2, Python 3.3, Python 3.4
Added file: http://bugs.python.org/file29126/reap_threads.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com