[issue17299] Test cPickle with real files

Serhiy Storchaka added the comment: Benjamin has fixed this in the changeset 6aab72424063. -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue17299] Test cPickle with real files

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file29433/test_cpickle_fileio.patch ___ Python tracker ___ ___ Python-bugs-

[issue17299] Test cPickle with real files

Serhiy Storchaka added the comment: Oh, yes. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue17299] Test cPickle with real files

Antoine Pitrou added the comment: I think you want to open the files in binary mode, not text mode. -- ___ Python tracker ___ ___ Pyth

[issue17299] Test cPickle with real files

Serhiy Storchaka added the comment: I'm not sure what is wrong and can't check on Windows, but it is possible that this patch fixes tests. Please check it if you can. -- Added file: http://bugs.python.org/file29433/test_cpickle_fileio.patch ___ Pytho

[issue17299] Test cPickle with real files

Changes by Serhiy Storchaka : -- resolution: fixed -> status: closed -> open ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue17299] Test cPickle with real files

Benjamin Peterson added the comment: I think this broke the 2.7 Windows bots. Please unbreak. -- nosy: +benjamin.peterson ___ Python tracker ___ _

[issue17299] Test cPickle with real files

Serhiy Storchaka added the comment: I'm a little polished the patch before committing. Thank you for the patch, Aman Shah. -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker

[issue17299] Test cPickle with real files

Roundup Robot added the comment: New changeset 8a0b5c9f04c2 by Serhiy Storchaka in branch '2.7': Issue #17299: Add test coverage for cPickle with file objects and general IO http://hg.python.org/cpython/rev/8a0b5c9f04c2 -- nosy: +python-dev ___ Python

[issue17299] Test cPickle with real files

Serhiy Storchaka added the comment: LGTM. You forgot to remove close() from some classes, I'll do it myself before committing. -- assignee: -> serhiy.storchaka stage: needs patch -> commit review ___ Python tracker

[issue17299] Test cPickle with real files

Aman Shah added the comment: Version 3. -- keywords: +patch Added file: http://bugs.python.org/file29383/issue17299v3.patch ___ Python tracker ___ ___

[issue17299] Test cPickle with real files

Serhiy Storchaka added the comment: DRY (do not repeat yourself). Do not implement the same method three times. Definitely the common code should be extracted into separate mixin classes: cStringIOMixin, BytesIOMixin, FileIOMixin. > What is the problem in using the existing pickletester.py??

[issue17299] Test cPickle with real files

Aman Shah added the comment: I have updated the patch for test_cpickle.py . Also, I would like to help out in creating mixins for the 3 but, it would be helpful if you can explain it in a bit more detail. What is the problem in using the existing pickletester.py?? -- Added file: http:/

[issue17299] Test cPickle with real files

Serhiy Storchaka added the comment: David, yes, this is 2.7 only issue. The code was broken recently (see msg182979 in issue13555) due to insufficient testing. -- ___ Python tracker ___

[issue17299] Test cPickle with real files

Serhiy Storchaka added the comment: I have added comments on Rietveld. Perhaps it will be worth to create mixings for cStringIO.StringIO, BytesIO and file object and then mix them to other tests. Note that there is no sense to change pure Python pickle tests. Python implementation uses the sa

[issue17299] Test cPickle with real files

Aman Shah added the comment: I had put in the renaming because "ioclass" is not defined in the class itself, only in the subclasses. So, instantiating it and using dumps/loads would be meaningless and would raise an error. Which is similar to the behavior of an abstract class. Also, the "if(se

[issue17299] Test cPickle with real files

R. David Murray added the comment: Aman: another nit: PEP8 calls for no unneeded parentheses around logical expressions, so things like: if(self.f): should be written: if self.f: in order to adhere to our coding style. Also, it's not obvious to me that there is any reason to rename th

[issue17299] Test cPickle with real files

Aman Shah added the comment: Fixed the patch by removing TESTFN from tearDown. -- Added file: http://bugs.python.org/file29267/patch ___ Python tracker ___ __

[issue17299] Test cPickle with real files

Aman Shah added the comment: Created a small patch for python 2.7 using file test_pickle.py . -- nosy: +Aman.Shah Added file: http://bugs.python.org/file29266/patch ___ Python tracker __

[issue17299] Test cPickle with real files

R. David Murray added the comment: Serhiy, in Python3 the corresponding test uses io.BytesIO. That means the additional tests are needed on Python3 as well, just a slightly different set, right? -- nosy: +r.david.murray ___ Python tracker

[issue17299] Test cPickle with real files

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue17299] Test cPickle with real files

New submission from Serhiy Storchaka: Currently cPickle module tested only with cStringIO.StringIO. However cPickle uses different code for cStringIO.StringIO, for file objects, and for general IO streams (i.e. io.BytesIO). Last two cases are not covered by tests. -- components: Tests