Berker Peksag added the comment:
Thanks for the reviews. Patch updated.
Éric, since the test file is relatively small, I went ahead and made some
cosmetic fixes, but I can open a new issue for them :)
--
Added file: http://bugs.python.org/file29680/test_print_v2.diff
Roundup Robot added the comment:
New changeset 178075fbff3a by Andrew Svetlov in branch 'default':
#17365: Remove Python 2 code from test_print
http://hg.python.org/cpython/rev/178075fbff3a
--
nosy: +python-dev
___
Python tracker
Andrew Svetlov added the comment:
Fixed.
Thanks, Berker
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17365
Andrew Svetlov added the comment:
Agree with Terry.
The patch LGTM except unicode literals part.
--
nosy: +asvetlov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17365
___
Éric Araujo added the comment:
The cosmetic changes to whitespace and parens seem like diff noise to me.
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17365
___
Terry J. Reedy added the comment:
In 3.3+ the u prefix is ignored in the lexer stage and I am sure that is tested
in the string literal syntax tests. It has nothing to do with printing. The
commented out tests you appropriately removed were testing the printing of
unicode instead of byte
New submission from Berker Peksag:
Changes:
* Removed Python 2 specific code
* Re-enabled u'' tests (see PEP 414)
* Cosmetic fixes
--
components: Tests
files: test_print.diff
keywords: patch
messages: 183581
nosy: berker.peksag
priority: normal
severity: normal
status: open
title:
