Roundup Robot added the comment:
New changeset fd80195b920f by Serhiy Storchaka in branch 'default':
Issue #17401: Output the closefd attribute as boolean.
https://hg.python.org/cpython/rev/fd80195b920f
--
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
Committed the first patch (showing closefd always) with additional test from
second path.
--
versions: -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17401
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: commit review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17401
___
Serhiy Storchaka added the comment:
Arfrever have suggested on IRC to backport documentation part of the patch to
3.4.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17401
___
Serhiy Storchaka added the comment:
FileIO repr now looks confusing:
sys.stdout.buffer.raw
_io.FileIO name='stdout' mode='wb' closefd='0'
The closefd attribute is not a string '0' or '1', it is boolean value True or
False. Here is a patch which fixes a repr.
And I think that documentation
Robert Collins added the comment:
Yeah thats nicer. I'll apply that later unless you can.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17401
___
Serhiy Storchaka added the comment:
May be include closefd in the repr only when it is False? By default closefd is
True and in common case the repr will be more compact.
--
Added file: http://bugs.python.org/file36979/io_fileio_repr_closefd_2.patch
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17401
___
Robert Collins added the comment:
Showing it only when False would have higher cognitive load. Showing it always
is simple and clear.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17401
Changes by Berker Peksag berker.pek...@gmail.com:
--
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17401
___
Changes by Robert Collins robe...@robertcollins.net:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17401
___
R. David Murray added the comment:
I think the information from the following line of the 'open' docs should be
added to the doc patch:
If a filename is given closefd has no effect and must be True (the default).
Otherwise it looks fine to me.
--
nosy: +r.david.murray
Roundup Robot added the comment:
New changeset a1500e4a159a by Robert Collins in branch 'default':
Issue #17401: document closefd in io.FileIO docs and add to repr
https://hg.python.org/cpython/rev/a1500e4a159a
--
nosy: +python-dev
___
Python tracker
Robert Collins added the comment:
Its more than just a docs issue - AFAICT it isn't possible to tell if closefd
is set after the object is created.
The presence of the parameter in the signature is there, but it isn't
documented *where the bulk of the FileIO parameters are* - there are docs
Robert Collins added the comment:
Oh - the the 'open' function docs are fine - they are just a pointer. I was
specifically referring to the class docs around line 513 of Doc/library/io.rst.
Attached is a patch that changes repr to show this attribute and extends the
docs to document this as
Mark Lawrence added the comment:
From the 3.5 docs.
io.open(file, mode='r', buffering=-1, encoding=None, errors=None, newline=None,
closefd=True, opener=None)
This is an alias for the builtin open() function.
There is a description for closefd at the open() function link. So how about
New submission from Robert Collins:
the docs (http://docs.python.org/3.x/library/io.html#io.FileIO) do not document
closefd, and AFAICT it isn't possible to tell if closefd is set after the
object is created. Specifically it does not show up in the repr().
import sys
sys.stdout
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
assignee: - docs@python
components: +Documentation, IO, Library (Lib)
nosy: +docs@python, pitrou
type: - enhancement
versions: -Python 3.5
___
Python tracker rep...@bugs.python.org
18 matches
Mail list logo
