[issue1757072] Zipfile robustness

Changes by Serhiy Storchaka : -- resolution: -> out of date stage: test needed -> resolved status: open -> closed ___ Python tracker ___ __

[issue1757072] Zipfile robustness

era added the comment: For those who cannot update just yet, see also the workaround at http://stackoverflow.com/a/21996397/874188 -- nosy: +era ___ Python tracker ___ ___

[issue1757072] Zipfile robustness

Mark Lawrence added the comment: I'm assuming that this can now be closed. -- nosy: +BreamoreBoy status: pending -> open ___ Python tracker ___

[issue1757072] Zipfile robustness

Serhiy Storchaka added the comment: Original issue was fixed in cc3255a707c7. Issue reported in msg73317 was fixed in issue14315. Is there something left about this issue? -- nosy: +serhiy.storchaka status: open -> pending ___ Python tracker

[issue1757072] Zipfile robustness

James C. Ahlstrom added the comment: For completeness, I checked other versions of Python. The example zip file fails in Python 3.1, but succeeds in Python 3.2.2. The patch for 3.2.2 removed the check for correct comment length, but substituted no further check for validity. -- __

[issue1757072] Zipfile robustness

R. David Murray added the comment: Here's the patch: http://hg.python.org/cpython/rev/cc3255a707c7/ I thought I remembered getting it in to 2.7.2, but my memory is evidently wrong. It has been applied, but is not yet in the released version of 2.7. -- __

[issue1757072] Zipfile robustness

James C. Ahlstrom added the comment: I grabbed a 2.7.2 zipfile.py, and my original comments stand. If there is a "garbage at end of file" patch, I can't find it; please provide a line number or a hint. The user at yale.edu reports that the patch works. Here is a diff of my changes. To tes

[issue1757072] Zipfile robustness

James C. Ahlstrom added the comment: Problem was reported on 2.7. I will check in detail this weekend. Please stand by. -- ___ Python tracker ___ __

[issue1757072] Zipfile robustness

R. David Murray added the comment: I'm pretty sure that what you are reporting has been fixed by the 'garbage' fix I mentioned (which might better be called the 'more flexible handling of comments' patch). Though not in 2.5 (or 2.6) since they are no longer in maintenance. If you could conf

[issue1757072] Zipfile robustness

James C. Ahlstrom added the comment: I received a bug report from a user. He had a zip file created by Mac OS 10.5.8 that the zipfile module claimed was not a valid zip file. The traceback went to function _EndRecData(fpin). The file had a valid comment appended, but recorded a comment len

[issue1757072] Zipfile robustness

R. David Murray added the comment: "This issue" is currently a collection point for specific "allow this in lax mode" issues. Do you have one or more specific cases in point that you'd like to talk about? (Note that the 'garbage after end of file' bug has already been fixed.) -- _

[issue1757072] Zipfile robustness

Changes by Florent Xicluna : -- nosy: +flox ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue1757072] Zipfile robustness

antitree added the comment: I'm still affected by this issue. A workaround or patch would be appreciated. -- nosy: +antitree ___ Python tracker ___ ___

[issue1757072] Zipfile robustness

Alan McIntyre added the comment: So far I haven't had the opportunity to sit down and write up a "lenient zipfile handling" patch; my apologies to those that could really use one. If somebody does propose a patch, I'll be glad to test and review it. I suppose I would like to see the issue ke

[issue1757072] Zipfile robustness

R. David Murray added the comment: Note that based on the fact that most zipfile tools handle garbage after the indicated end of the comment by ignoring it, #10694 fixed zipfile to also ignore such trailing data. It sounds like there may be more out-of-spec errors that could be ignored, thou

[issue1757072] Zipfile robustness

Changes by Ernst Sjöstrand : -- nosy: +Ernst.Sjöstrand ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue1757072] Zipfile robustness

Mark Hirota added the comment: Yes, I'd be interested in this functionality. Anything that makes it more flexible to use with a wide variety of zipfiles (even bad ones :D) allows for increased reusability. Thanks! -- ___ Python tracker

[issue1757072] Zipfile robustness

Alan McIntyre added the comment: Maybe ZipFile should have an option to handle archives in a non-strict mode, in which it would raise warnings or just completely ignore a small set of minor violations of the spec. That way people that want behavior that's in compliance with the spec will hav

[issue1757072] Zipfile robustness

Changes by Terry J. Reedy : -- stage: -> unit test needed versions: +Python 3.2 -Python 2.7, Python 3.1 ___ Python tracker ___ ___

[issue1757072] Zipfile robustness

Mark Hirota <[EMAIL PROTECTED]> added the comment: I'd like to piggyback on this issue if okay :D I have some zipfiles I'm working with that contain junk in the extra fields. The ZipFile object croaks at the call to the ZipInfo._decodeExtra() call when it could really just ignore the error. E

[issue1757072] Zipfile robustness

Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- type: -> feature request versions: +Python 2.7, Python 3.1 -Python 2.5 ___ Python tracker <[EMAIL PROTECTED]> ___

[issue1757072] Zipfile robustness

Chris Mellon added the comment: I agree that the zipfile is out of spec. Here are my arguments in favor of making the change anyway: Existing zip tools like 7zip, pkzip, and winzip handle these files "as expected" As far as I know, it won't break any valid zipfiles. Because the fix necessary i

[issue1757072] Zipfile robustness

Alan McIntyre added the comment: It would seem that such a zip file is not consistent with the spec (http://www.pkware.com/documents/casestudies/APPNOTE.TXT). My first reaction is that we shouldn't accept behavior outside the spec unless it's something that's done by many popular ZIP application

[issue1757072] Zipfile robustness

Changes by Georg Brandl: -- assignee: aimacintyre -> _ Tracker <[EMAIL PROTECTED]> _ ___ Python-bugs-list mailing list Unsubscribe:

[issue1757072] Zipfile robustness

Georg Brandl added the comment: Alan? -- assignee: -> aimacintyre nosy: +gbrandl _ Tracker <[EMAIL PROTECTED]> _ ___ Python-bugs-lis