[issue17573] add ElementTree XML processing benchmark to benchmark suite

[Antoine Pitrou]

Antoine Pitrou added the comment:

I've committed the benchmarks after some changes:
- smaller document to reduce runtimes
- avoid measuring processing and serializing performance as part of the parsing 
benchmark
- added an iterparse benchmark (iterparse can be important for e.g. XMPP 
implementations)

--
stage:  -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17573] add ElementTree XML processing benchmark to benchmark suite

[Roundup Robot]

Roundup Robot added the comment:

New changeset 723d7f134cf5 by Antoine Pitrou in branch 'default':
Tweak etree benchmarks and add an etree_iterparse benchmark (followup to issue 
#17573).
http://hg.python.org/benchmarks/rev/723d7f134cf5

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17573] add ElementTree XML processing benchmark to benchmark suite

[Roundup Robot]

Roundup Robot added the comment:

New changeset dbf5693d7013 by Antoine Pitrou in branch 'default':
Issue #17573: add three elementtree benchmarks.  Initial patch by Stefan Behnel.
http://hg.python.org/benchmarks/rev/dbf5693d7013

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17573] add ElementTree XML processing benchmark to benchmark suite

[Stefan Behnel]

Stefan Behnel added the comment:

Ok, but an lxml benchmark is independent from this patch then. I updated it to 
only use cElementTree, with the additional "--etree-module" option and also a 
"--no-accelerator" option for advanced usage.

Another thing I did is to split the actual benchmark code into three: one that 
does parse-process-serialise, one that only does process-serialise, and one 
that does only generate-serialise. The intention is to also represent the use 
case of just getting stuff out, instead of always getting everything in through 
the parser.

--
Added file: http://bugs.python.org/file29612/add_et_benchmark.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17573] add ElementTree XML processing benchmark to benchmark suite

[Antoine Pitrou]

Antoine Pitrou added the comment:

> I'm ok with the conditional import for ET, although I don't see a
> reason to exclude it. Why not be able to compare the performance of
> both implementations as well? There's a slowpickle benchmark, for
> example.

It made sense in 2.7 where both implementations were visibly selectable
(and the pure Python ones were arguably the "default" choice since their
names were less obtuse). But in 3.3 the C accelerator is automatically
enabled when importing xml.etree. So I don't think making a difference
makes much sense anymore.

> So, what about only testing cET by default and adding an explicit
> option "--etree-module=package.module" to change the imported module,
> e.g. "--etree-module=lxml.etree" to benchmark lxml or
> "--etree-module=cElementTree" to benchmark a separately installed 3rd
> party cET package?

Well, we could still add a "lxml" benchmark but disable it by default (I
mean not make it part of the main sub-suites). That way people can run
it explicitly if they want.

(also, since it's a "lxml" benchmark, it may test other things than
simply the etree API, if you like)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17573] add ElementTree XML processing benchmark to benchmark suite

[Stefan Behnel]

Stefan Behnel added the comment:

I considered lxml.etree support more of a convenience feature, just for 
comparison. Given that it's a binary package that doesn't run reliably on other 
Python implementations apart of CPython, I don't think it's really interesting 
to make it part of the benchmark suite. I'd rather add an explicit option to 
enable it than include it there.

I'm ok with the conditional import for ET, although I don't see a reason to 
exclude it. Why not be able to compare the performance of both implementations 
as well? There's a slowpickle benchmark, for example.

So, what about only testing cET by default and adding an explicit option 
"--etree-module=package.module" to change the imported module, e.g. 
"--etree-module=lxml.etree" to benchmark lxml or "--etree-module=cElementTree" 
to benchmark a separately installed 3rd party cET package?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17573] add ElementTree XML processing benchmark to benchmark suite

[Antoine Pitrou]

Antoine Pitrou added the comment:

Haven't looked at the patch in detail but a couple of things:

- I don't think we need to benchmark the slow pure-Python ET, except when the 
fast version isn't present (basically, the main benchmark should try cET and 
then fallback on ET)

- I'm ok with lxml being benchmarked, but only if a well-defined version is 
included in the source tree (the problem being of course that it's not pure 
Python, so it will have to be built on the fly, assuming all dependencies are 
present :-/)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17573] add ElementTree XML processing benchmark to benchmark suite

[Stefan Behnel]

Changes by Stefan Behnel :


--
nosy: +brett.cannon, pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17573] add ElementTree XML processing benchmark to benchmark suite

[Stefan Behnel]

New submission from Stefan Behnel:

Here is an artificial but pretty broad ElementTree benchmark, testing the 
modules xml.etree.ElementTree, xml.etree.cElementTree and lxml.etree (if 
importable). Please add it to the benchmark suite.

--
components: Benchmarks, XML
files: add_et_benchmark.patch
keywords: patch
messages: 185496
nosy: scoder
priority: normal
severity: normal
status: open
title: add ElementTree XML processing benchmark to benchmark suite
type: enhancement
Added file: http://bugs.python.org/file29603/add_et_benchmark.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com