[issue17614] IDLE - quickly closing a large file triggers a traceback

[Roger Serwy]

Changes by Roger Serwy :


--
resolution:  -> fixed
stage: commit review -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17614] IDLE - quickly closing a large file triggers a traceback

[Roundup Robot]

Roundup Robot added the comment:

New changeset 1e5e497ee33b by Roger Serwy in branch '2.7':
#17614: IDLE no longer raises exception when quickly closing a file.
http://hg.python.org/cpython/rev/1e5e497ee33b

New changeset d759b7bc9785 by Roger Serwy in branch '3.3':
#17614: IDLE no longer raises exception when quickly closing a file.
http://hg.python.org/cpython/rev/d759b7bc9785

New changeset 578edbe38f0a by Roger Serwy in branch 'default':
#17614: merge with 3.3.
http://hg.python.org/cpython/rev/578edbe38f0a

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17614] IDLE - quickly closing a large file triggers a traceback

[Roger Serwy]

Roger Serwy added the comment:

Updated patch based on Ezio's comments. Thank you, Ezio!

Senthil, I wish I had a Mac to test against. I am able to trigger the bug on 
Win7 with 3.3.

Without objection, I will commit the patch in the upcoming hours.

--
assignee:  -> roger.serwy
Added file: http://bugs.python.org/file29659/issue17614_rev1.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17614] IDLE - quickly closing a large file triggers a traceback

[Ezio Melotti]

Changes by Ezio Melotti :


--
priority: critical -> high
versions:  -Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17614] IDLE - quickly closing a large file triggers a traceback

[Ned Deily]

Changes by Ned Deily :


--
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17614] IDLE - quickly closing a large file triggers a traceback

[Ned Deily]

Ned Deily added the comment:

LGTM

--
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17614] IDLE - quickly closing a large file triggers a traceback

[Roger Serwy]

Roger Serwy added the comment:

I forgot to specify that the race condition gets triggered by pressing Alt-F4 
the moment the IDLE editor window appears. 

I am reliably reproducing the error using the Konsole terminal under Arch Linux.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17614] IDLE - quickly closing a large file triggers a traceback

[Senthil Kumaran]

Senthil Kumaran added the comment:

Is there a better way to reproduce the error in the first place.
On 2.7 tip,
./python -m idelib.idle
Opened and closed bigfile.py and decimal.py - and could not reproduce the 
error. If I could, I could have tested the patch.

--
nosy: +orsenthil

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17614] IDLE - quickly closing a large file triggers a traceback

[Roger Serwy]

Roger Serwy added the comment:

Like #17613, the root cause is a call to .update() in Lib/idlelib/PyShell.py 
.restore_file_breaks().

The attached patch fixes the issue.

--
keywords: +patch
stage:  -> patch review
Added file: http://bugs.python.org/file29651/issue17614.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17614] IDLE - quickly closing a large file triggers a traceback

[Roger Serwy]

New submission from Roger Serwy:

Using the bigfile.py generation program from #17613 triggers the following 
traceback:

Traceback (most recent call last):
  File "/usr/bin/idle", line 5, in 
main()
  File "/usr/lib/python3.3/idlelib/PyShell.py", line 1431, in main
if flist.open(filename) is None:
  File "/usr/lib/python3.3/idlelib/FileList.py", line 36, in open
edit = self.EditorWindow(self, filename, key)
  File "/usr/lib/python3.3/idlelib/PyShell.py", line 113, in __init__
if self.io.filename: self.restore_file_breaks()
  File "/usr/lib/python3.3/idlelib/PyShell.py", line 229, in restore_file_breaks
filename = self.io.filename
AttributeError: 'NoneType' object has no attribute 'filename'

--
components: IDLE
messages: 185802
nosy: roger.serwy
priority: critical
severity: normal
status: open
title: IDLE - quickly closing a large file triggers a traceback
type: behavior
versions: Python 2.7, Python 3.2, Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17614] IDLE - quickly closing a large file triggers a traceback

[Roger Serwy]

Roger Serwy added the comment:

I misworded the first sentence. It should have read: "Using bigfile.py as 
generated by the program in #17613 can trigger the following traceback when 
quickly closing the editor."

Other large files can be used to trigger the bug as well, like Lib/decimal.py.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com