[issue17625] IDLE regression -- Search and Replace Window doesn't automatically clear

2013-04-06 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 13e5664c5d19 by Benjamin Peterson in branch '3.2':
close search and replace dialog after it is used (closes #17625)
http://hg.python.org/cpython/rev/13e5664c5d19

New changeset 7746d238c4bb by Benjamin Peterson in branch '3.3':
close search and replace dialog after it is used (closes #17625)
http://hg.python.org/cpython/rev/7746d238c4bb

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17625
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17625] IDLE regression -- Search and Replace Window doesn't automatically clear

2013-04-04 Thread Georg Brandl

Georg Brandl added the comment:

Done, thanks.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17625
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17625] IDLE regression -- Search and Replace Window doesn't automatically clear

2013-04-03 Thread Raymond Hettinger

New submission from Raymond Hettinger:

In an editor window, select Edit-Replace and click ReplaceAll.  The dialog 
window stays open.   Formerly, it cleared immediately which was useful.  The 
new behavior is confusing and less useful.

--
assignee: roger.serwy
components: IDLE
messages: 185917
nosy: rhettinger, roger.serwy
priority: normal
severity: normal
status: open
title: IDLE regression -- Search and Replace Window doesn't automatically clear
versions: Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17625
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17625] IDLE regression -- Search and Replace Window doesn't automatically clear

2013-04-03 Thread Roger Serwy

Roger Serwy added the comment:

That behavior was introduced as part of the patch I wrote a long time ago for 
#13052. In retrospect that extra functionality went beyond the scope of that 
issue and should not have been included.

Does anyone else think that the new behavior ought to be reverted? I don't mind 
reverting it.

A related issue is #17511 which wants to keep the Find dialog open instead of 
closing.

--
stage:  - needs patch
type:  - behavior
versions: +Python 3.3, Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17625
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17625] IDLE regression -- Search and Replace Window doesn't automatically clear

2013-04-03 Thread Roger Serwy

Roger Serwy added the comment:

The attached patch restores the original behavior.

--
keywords: +patch
stage: needs patch - patch review
Added file: http://bugs.python.org/file29674/issue17625.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17625
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17625] IDLE regression -- Search and Replace Window doesn't automatically clear

2013-04-03 Thread Raymond Hettinger

Raymond Hettinger added the comment:

Thanks.  Please go ahead and apply it.  I'm teaching some Python classes right 
now using the 2.7.4rc1 and the students are tripping over the new behavior.

--
priority: normal - high

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17625
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17625] IDLE regression -- Search and Replace Window doesn't automatically clear

2013-04-03 Thread Raymond Hettinger

Changes by Raymond Hettinger raymond.hettin...@gmail.com:


--
nosy: +benjamin.peterson, georg.brandl, larry
priority: high - release blocker

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17625
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17625] IDLE regression -- Search and Replace Window doesn't automatically clear

2013-04-03 Thread Roger Serwy

Roger Serwy added the comment:

If students are having trouble, then it should be changed. This behavior is 
also in 3.2. 

Do applied patches in 2.7 tip go toward 2.7.4 or 2.7.5? (I don't know the 
mechanics of the release candidate process just yet.)

--
stage: patch review - commit review
versions: +Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17625
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17625] IDLE regression -- Search and Replace Window doesn't automatically clear

2013-04-03 Thread Benjamin Peterson

Benjamin Peterson added the comment:

I'll handle it.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17625
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17625] IDLE regression -- Search and Replace Window doesn't automatically clear

2013-04-03 Thread Roundup Robot

Roundup Robot added the comment:

New changeset edcfd18840cc by Benjamin Peterson in branch '2.7':
close search and replace dialog after it is used (closes #17625)
http://hg.python.org/cpython/rev/edcfd18840cc

New changeset 36130b84cd22 by Benjamin Peterson in branch '3.3':
close search and replace dialog after it is used (closes #17625)
http://hg.python.org/cpython/rev/36130b84cd22

New changeset a6c2210220dd by Benjamin Peterson in branch 'default':
merge 3.3 (#17625)
http://hg.python.org/cpython/rev/a6c2210220dd

--
nosy: +python-dev
resolution:  - fixed
stage: commit review - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17625
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17625] IDLE regression -- Search and Replace Window doesn't automatically clear

2013-04-03 Thread Benjamin Peterson

Benjamin Peterson added the comment:

Over to Georg for 3.3 cherry picking.

--
assignee: roger.serwy - georg.brandl

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17625
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com