[issue17633] zipimport's handling of namespace packages is incorrect

Roundup Robot added the comment: New changeset 07a615a8f9ad by Brett Cannon in branch '3.5': Issue #17633: Improve support for namespace packages with zipimport. https://hg.python.org/cpython/rev/07a615a8f9ad New changeset 87f87673af7b by Brett Cannon in branch 'default': Merge for issue #17633

[issue17633] zipimport's handling of namespace packages is incorrect

Brett Cannon added the comment: The fix for 3.5 is in https://hg.python.org/cpython/rev/07a615a8f9ad and 3.6 in https://hg.python.org/cpython/rev/87f87673af7b. Thanks to Phil and Mike for tackling this problem! -- resolution: -> fixed stage: patch review -> resolved status: open -> cl

[issue17633] zipimport's handling of namespace packages is incorrect

Mike Romberg added the comment: This patch modifies issue17633-hg.diff by adding changes suggested by the reviewers. Note. I did cleanup the use of __import__ outside of the area involved with issue17633 as it seemed low risk. The tests for issue17633 (and the refactored doTest/makeZip no

[issue17633] zipimport's handling of namespace packages is incorrect

Brett Cannon added the comment: Nope, looks like it worked! I will try to have a look at the patch some time this week. And for future reference, you can also use https://docs.python.org/devguide/patch.html as a guide. -- assignee: -> brett.cannon ___

[issue17633] zipimport's handling of namespace packages is incorrect

Mike Romberg added the comment: Try issue17633-hg.diff. Caution it was made after literally minutes of experience with hg. :) I checked out the source applied the changes, compiled and ran 'make test' (gdb still fails), and did an hg commit. The diff was made following the instructions

[issue17633] zipimport's handling of namespace packages is incorrect

Mike Romberg added the comment: Yes. I can do this. I've not used hg before. But I bet I can figure it out. I'm assuming hg has a diff/pach genterator of some kind ('hg diff' perhaps). Lemme try and find the hg repository and check out a copy... -- __

[issue17633] zipimport's handling of namespace packages is incorrect

Brett Cannon added the comment: Any chance you can do the diff against an hg checkout, Mike? That way we can use our review tool to do the code review, else we have to work only from the raw diff file which isn't as nice. -- ___ Python tracker

[issue17633] zipimport's handling of namespace packages is incorrect

Mike Romberg added the comment: I have expanded on the issue17633-2 patch to fix an issue with the enumerated value returned by find_loader(). The patch (issue17633-3.diff) is against 3.5.1. I have also added more test cases that cover spreading a namespace package across two zip files and

[issue17633] zipimport's handling of namespace packages is incorrect

Changes by Eric Snow : -- nosy: +gregory.p.smith, superluser versions: +Python 3.6 -Python 3.5 ___ Python tracker ___ ___ Python-bugs-

[issue17633] zipimport's handling of namespace packages is incorrect

Changes by Eric Snow : -- stage: -> patch review type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue17633] zipimport's handling of namespace packages is incorrect

Changes by Thomas Heller : -- nosy: +theller ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue17633] zipimport's handling of namespace packages is incorrect

Changes by Eric V. Smith : -- keywords: +needs review versions: +Python 3.5 -Python 3.4 ___ Python tracker ___ ___ Python-bugs-list ma

[issue17633] zipimport's handling of namespace packages is incorrect

Phil Connell added the comment: Updated patch with markups suggested by Serhiy. -- Added file: http://bugs.python.org/file29927/issue17633-2.diff ___ Python tracker ___ _

[issue17633] zipimport's handling of namespace packages is incorrect

Phil Connell added the comment: The attached patch is ready for review. -- Added file: http://bugs.python.org/file29925/issue17633.diff ___ Python tracker ___ ___

[issue17633] zipimport's handling of namespace packages is incorrect

Changes by Phil Connell : Removed file: http://bugs.python.org/file29696/test.diff ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue17633] zipimport's handling of namespace packages is incorrect

Changes by Phil Connell : Removed file: http://bugs.python.org/file29679/zipimport_ns.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue17633] zipimport's handling of namespace packages is incorrect

Phil Connell added the comment: Here's a test that fails without the patch and succeeds with the patch. -- Added file: http://bugs.python.org/file29696/test.diff ___ Python tracker _

[issue17633] zipimport's handling of namespace packages is incorrect

Changes by Phil Connell : Added file: http://bugs.python.org/file29679/zipimport_ns.diff ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue17633] zipimport's handling of namespace packages is incorrect

Changes by Phil Connell : Removed file: http://bugs.python.org/file29679/zipimport_ns.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue17633] zipimport's handling of namespace packages is incorrect

Eric V. Smith added the comment: Could you construct a test (that would fail without your patch)? Thanks. -- ___ Python tracker ___ _

[issue17633] zipimport's handling of namespace packages is incorrect

Changes by Eric V. Smith : -- nosy: +eric.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue17633] zipimport's handling of namespace packages is incorrect

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue17633] zipimport's handling of namespace packages is incorrect

Changes by Phil Connell : -- nosy: +isoschiz ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue17633] zipimport's handling of namespace packages is incorrect

New submission from Phil Connell: Only one level of namespace package nesting is handled correctly: $ unzip -l foo.zip Archive: foo.zip Length DateTimeName - -- - 0 2013-04-03 17:28 a/b/c/foo.py 0 2013-04-03 17:34 a/ 0 20