R. David Murray added the comment:
The patch looks good to me. Can you add a pickling test?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17818
___
Claudiu.Popa added the comment:
Here's the new patch. Also, I noticed a test failing when running ./python -m
test, pyclbr, complaining about _Aifc_params not present in some dict, but I
don't really know how to fix it..
--
Added file: http://bugs.python.org/file31034/aifc_4.patch
R. David Murray added the comment:
pyclbr is parsing the source code, and since _Aifc_params is not a class, it
does not get detected. So we just need to add it to the ignore list in the
pyclbr test.
I'm also getting this when I run the test with your patch applied:
Claudiu.Popa added the comment:
Here's the new modifications.
--
Added file: http://bugs.python.org/file31036/aifc_5.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17818
___
Roundup Robot added the comment:
New changeset 560c6e9d1beb by R David Murray in branch 'default':
#17818: aifc.getparams now returns a namedtuple.
http://hg.python.org/cpython/rev/560c6e9d1beb
--
nosy: +python-dev
___
Python tracker
R. David Murray added the comment:
Thanks, Claudiu.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17818
Claudiu.Popa added the comment:
Can anyone review the latest patch, please? Thanks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17818
___
___
R. David Murray added the comment:
I've got it on my list, but I'm very busy for the next couple weeks. If
someone else gets to it first that's good too :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17818
Claudiu.Popa added the comment:
I've modified the patch according to your comments, thanks! Now the result of
getparams() is picklable again.
--
Added file: http://bugs.python.org/file30052/aifc_3.patch
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
There is a regression. The result of getparams() was pickable, but now it is
not.
I have added other comments on Rietveld.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17818
R. David Murray added the comment:
I made review comments: patch looks good, tests need a bit of work. Would you
be interested in adding the What's New entry as well? (Doc/whatsnew/3.4).
--
stage: - patch review
___
Python tracker
Claudiu.Popa added the comment:
Hello. I changed the patch according to your review comments. Here is the new
version.
--
Added file: http://bugs.python.org/file30028/aifc_2.patch
___
Python tracker rep...@bugs.python.org
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +r.david.murray, serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17818
___
___
Changes by Claudiu.Popa pcmantic...@gmail.com:
Added file: http://bugs.python.org/file29988/aifc_1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17818
___
New submission from Claudiu.Popa:
Hello!
Given the fact that issue 17487 was accepted, I think that is a good idea for
aifc.Aifc_read/Aifc_write.getparams to return a namedtuple as well, so that
both modules will behave consistently with each other.
I've attached a patch for this.
Thanks in
15 matches
Mail list logo
