[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

[Martin Panter]

Changes by Martin Panter :


Added file: http://bugs.python.org/file30108/7691d1d4b955.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

[paul j3]

paul j3 added the comment:

I just submitted a patch to http://bugs.python.org/issue11874 that 
substantially rewrites _format_actions_usage().  It generates the group and 
action parts separately, and does not do the kind of cleanup that produces this 
issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

[R. David Murray]

R. David Murray added the comment:

I've been observing the activity on the argparse issues and am appreciating the 
work, but I don't have time right now to review the patches.  I should have 
more time next month, and expect to get to them then, if no one else gets to 
them before I do.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

[Yogesh Chaudhari]

Yogesh Chaudhari added the comment:

@terry and @paul:
I have 2 argparse related patches, sitting idle for quiet sometime now. Can you 
suggest any more names who can take this forward? (I could not find anyone else 
related to argparse in http://docs.python.org/devguide/experts.html)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

[paul j3]

paul j3 added the comment:

I'm following a dozen argparse issues with patches.  I haven't seen much 
posting by argparse experts (like bethard, david.murry) since last December.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

[Terry J. Reedy]

Terry J. Reedy added the comment:

Argparse is out of my area of competence/experience. I have added a couple of 
people who have worked on argparse in the past and should be better able to 
review or suggest another reviewer.

--
nosy: +bethard, r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

[Yogesh Chaudhari]

Yogesh Chaudhari added the comment:

@Terry: Thanks for the info. I seem to have the elusive "*" after my username 
now. I am not sure how this works, but can you review/test/apply the patch now?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

[Terry J. Reedy]

Terry J. Reedy added the comment:

Wait a week and see what happens.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

[Yogesh Chaudhari]

Yogesh Chaudhari added the comment:

I am not sure if I am missing something. I had filled out the form at 
http://www.python.org/psf/contrib/contrib-form/ on the day I submitted the 
patch and even got back an email from Ewa Jodlowska. However, I don't see any 
"*" after my name. I submitted the same form to contribut...@python.org and 
shot a mail to python-dev mailing list but there is no change. Any suggestions?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

[Terry J. Reedy]

Terry J. Reedy added the comment:

Garrett and Yogesh, please submit contributor license agreements
http://www.python.org/psf/contrib/contrib-form/
if you have not yet. When one is properly recorded, a * appears after your name.

--
nosy: +terry.reedy
versions: +Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

[paul j3]

paul j3 added the comment:

I see three solutions - 

1) gholms' patch which removes '() ' and [] '

2) Yogesh's patch which removes all duplicated spaces.

3) remove the 2 asserts. 

The first 2 do the same thing most of the time, but may differ if the user 
somehow inserts spaces into names.  The third leaves the extra blanks, but 
renders them innocuous.  I doubt if the asserts were written to catch this 
problem.  They probably were included to verify the usage line had been split 
up as expected prior to reassembling on multiple lines.

As best I can tell test_argparse.py does not test for these spaces.  Curiously 
though a port of argparse to javascript does have a test case with the extra 
space.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

[Yogesh Chaudhari]

Yogesh Chaudhari added the comment:

A user generated line with multiple spaces may be essential if we are getting 
the usage data (particularly from) a csv file (that may have random spaces in 
certain fields) or some other form of stored or auto-generated data.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

[paul j3]

paul j3 added the comment:

In the test case: class TestMutuallyExclusiveManySuppressed
even with a short 'eggs' argument, there is a difference

Old usage would be:

usage: PROG [-h]  [--eggs EGGS]

new

usage: PROG [-h] [--eggs EGGS]

i.e. 2 v 1 space.  But extra spaces are not as dramatic a failure as an 
assertion error.

It would also be good to check what happens when there are 2 suppressed groups. 
 If the text before all trimming is:

[ -h ] [] () [ --eggs EGGS ]

does it reduce to?

[-h] [--eggs EGGS]

The old code would have left 3 spaces.

I can't think of a situation in which a user would want a (generated) usage 
line with multiple spaces.  If some sort of special formatting is needed, there 
is always the option of specifying an explicit usage line.

parser = ArugmentParser(usage='one \ttwo  \nthree   four')

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

[Yogesh Chaudhari]

Changes by Yogesh Chaudhari :


Removed file: http://bugs.python.org/file30108/7691d1d4b955.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

[Yogesh Chaudhari]

Yogesh Chaudhari added the comment:

Made similar required changes for version 2.7

--
nosy: +Yogesh.Chaudhari
Added file: http://bugs.python.org/file30110/Issue17890-27.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

[Yogesh Chaudhari]

Changes by Yogesh Chaudhari :


--
keywords: +patch
Added file: http://bugs.python.org/file30108/7691d1d4b955.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

[paul j3]

paul j3 added the comment:

Looks like the 

text = text.strip()

at the end of the set of regex (in _format_actions_usage) needs to be replaced 
with something that removes all excess spaces, e.g.

text = _re.sub( '\s+', ' ', text ).strip()

--
nosy: +paul.j3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

[Garrett Holmstrom]

Changes by Garrett Holmstrom :


--
hgrepos: +187

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17890] argparse: mutually exclusive groups full of suppressed args can cause AssertionErrors

[Garrett Holmstrom]

New submission from Garrett Holmstrom:

When it goes to format a usage message, argparse seems to (correctly) fail to 
satisfy one of its assertions when all of the following are true:

1. A mutually exclusive group contains only args that are suppressed
2. An unsuppressed arg follows that group
3. The usage is long enough to need to line-wrap

The cause seems to be that the set of regular expressions that argparse uses to 
clean up mutually exclusive groups' separators doesn't handle the space that 
follows what would otherwise be an empty pair of square braces, sort of like 
this:

1. [-h] [ ] [--spam] ...
2. [-h] [] [--spam] ...
3. [-h]  [--spam] ...

A test case is attached.  I was able to reproduce this with 
python-2.7.3-13.fc18.x86_64 on Fedora as well as with commit 83588:e6b962fa44bb 
in 3.4 mainline.  I have a small patch for the latter that I'll submit shortly.

Sorry if I missed anything.  This is my first bug report against python proper.

--
components: Library (Lib)
files: argparse-assertfail.py
messages: 188250
nosy: gholms
priority: normal
severity: normal
status: open
title: argparse: mutually exclusive groups full of suppressed args can cause 
AssertionErrors
type: behavior
versions: Python 2.7, Python 3.4
Added file: http://bugs.python.org/file30102/argparse-assertfail.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com