[issue18007] CookieJar expects request objects with origin_req_host attribute instead of method

2013-05-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 26ac5b9cffda by Senthil Kumaran in branch '3.3': Fix #18007 : Document CookieJar.add_cookie_header request parameter changes in 3.3 http://hg.python.org/cpython/rev/26ac5b9cffda New changeset f7992397e98d by Senthil Kumaran in branch 'default':

[issue18007] CookieJar expects request objects with origin_req_host attribute instead of method

2013-05-23 Thread Senthil Kumaran
Senthil Kumaran added the comment: This change is documented. Thanks for the report. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18007 ___

[issue18007] CookieJar expects request objects with origin_req_host attribute instead of method

2013-05-22 Thread Senthil Kumaran
Senthil Kumaran added the comment: Hello Simon, Thanks for bringing this to attention. Since get_origin_req_host has been under deprecation was a release, I thought it was safe to remove that. Agree that documentation of cookiejar methods, which had a dependency on the change should have

[issue18007] CookieJar expects request objects with origin_req_host attribute instead of method

2013-05-21 Thread Simon Nicolussi
Simon Nicolussi added the comment: Requests 1.2.1 has been released to address this issue. An origin_req_host property has been added to the request object as a workaround. The original problem of mismatched documentation and behaviour still persists. --

[issue18007] CookieJar expects request objects with origin_req_host attribute instead of method

2013-05-18 Thread Simon Nicolussi
New submission from Simon Nicolussi: A fix for a DeprecationWarning (#17678) had the unfortunate side effect of changing the expected interface of the request object higher up in the call stack. For example, the documentation for CookieJar.add_cookie_header(request) states that the request