[issue18011] Inconsistency between b32decode() documentation, docstring and code

R. David Murray added the comment: But code could be catching TypeError specifically looking for the alphabet error, since that is how it was documented. -- ___ Python tracker _

[issue18011] Inconsistency between b32decode() documentation, docstring and code

Serhiy Storchaka added the comment: This is not incompatible change because b32decode() already raised this type of an error. Third-party code which use b32decode() was either incorrect (if it catches only TypeError or binascii.Error when any of them could raised) or is not broken by this chan

[issue18011] Inconsistency between b32decode() documentation, docstring and code

R. David Murray added the comment: For future reference, because this patch changed the type of an error, it should not have been applied to a maintenance release (3.3). Since the change has already been released in 3.3.3, it is now better not to revert it. -- nosy: +r.david.murray _

[issue18011] Inconsistency between b32decode() documentation, docstring and code

Roundup Robot added the comment: New changeset 29a823f31465 by Serhiy Storchaka in branch 'default': Issue #18011: Silence an unrelated noise introduced in changeset 1b5ef05d6ced. http://hg.python.org/cpython/rev/29a823f31465 -- ___ Python tracker

[issue18011] Inconsistency between b32decode() documentation, docstring and code

Roundup Robot added the comment: New changeset 0b9bcb2ac145 by Serhiy Storchaka in branch '3.3': Issue #18011: base64.b32decode() now raises a binascii.Error if there are http://hg.python.org/cpython/rev/0b9bcb2ac145 New changeset 7446f53ba2d2 by Serhiy Storchaka in branch 'default': Issue #1801

[issue18011] Inconsistency between b32decode() documentation, docstring and code

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue18011] Inconsistency between b32decode() documentation, docstring and code

Serhiy Storchaka added the comment: Are there any objections? -- assignee: docs@python -> serhiy.storchaka ___ Python tracker ___ ___

[issue18011] Inconsistency between b32decode() documentation, docstring and code

Changes by Ethan Furman : -- nosy: +ethan.furman ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue18011] Inconsistency between b32decode() documentation, docstring and code

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file30311/b32decode_exception.patch ___ Python tracker ___ ___ Python-bugs-

[issue18011] Inconsistency between b32decode() documentation, docstring and code

Changes by Serhiy Storchaka : -- Removed message: http://bugs.python.org/msg189577 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue18011] Inconsistency between b32decode() documentation, docstring and code

Serhiy Storchaka added the comment: Here is a patch which changes TypeError to binascii.Error in b32decode() and fixes the documentation and tests. -- Added file: http://bugs.python.org/file30311/b32decode_exception.patch ___ Python tracker

[issue18011] Inconsistency between b32decode() documentation, docstring and code

Serhiy Storchaka added the comment: Here is a patch which changes TypeError to binascii.Error in b32decode() and fixes the documentation and tests. -- keywords: +patch stage: -> patch review Added file: http://bugs.python.org/file30310/b32decode_exception.patch ___

[issue18011] Inconsistency between b32decode() documentation, docstring and code

New submission from Serhiy Storchaka: b32decode() documentation says: "A TypeError is raised if s were incorrectly padded or if there are non-alphabet characters present in the string." b32decode() docstring says: "binascii.Error is raised if the input is incorrectly padded or if there are non