Roundup Robot added the comment:
New changeset 3685d8074203 by R David Murray in branch '3.3':
#18179: document the local_hostname parameter.
http://hg.python.org/cpython/rev/3685d8074203
New changeset b10fae8c185c by R David Murray in branch 'default':
Merge #18179: document the local_hostname
R. David Murray added the comment:
Thanks Berker. I edited your patch to (a) use 'Otherwise' instead of 'By
default', which is a change from the original docstring that I think makes it
clearer, (b) add words about what the local_hostname is used for (the HELO/EHLO
commands) and (c) in
Changes by A.M. Kuchling li...@amk.ca:
--
nosy: +akuchling
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18179
___
___
Python-bugs-list mailing
Changes by Berker Peksag berker.pek...@gmail.com:
--
keywords: +patch
stage: needs patch - patch review
Added file: http://bugs.python.org/file30572/issue18179.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18179
New submission from Jonas H.:
The Sphinx docs don't contain any explanation for `local_hostname`.
--
assignee: docs@python
components: Documentation
messages: 190898
nosy: docs@python, jonash
priority: normal
severity: normal
status: open
title: SMTP.local_hostname is undocumented
Berker Peksag added the comment:
The docstring of the SMTP class says:
If specified, `local_hostname` is used as the FQDN of the local host. By
default, the local hostname is found using socket.getfqdn().
See Lib/smtplib.py:226.
--
nosy: +berker.peksag
versions: -Python 2.6, Python
R. David Murray added the comment:
SMTP.local_hostname is probably a private attribute of the SMTP class, dating
from before we started getting strict about having private attributes start
with '_'. However, I see no reason to keep it private; we might as well just
document it, since I'm
