[issue18192] Move imp.get_magic() to importlib

2013-06-14 Thread Brett Cannon
Brett Cannon added the comment: Any chance I could get a response to my questions, Barry, soon? I think I can finish the rest of the issues related to deprecating imp this weekend if we can settle this quickly. -- ___ Python tracker

[issue18192] Move imp.get_magic() to importlib

2013-06-14 Thread Brett Cannon
Changes by Brett Cannon br...@python.org: -- assignee: - barry ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18192 ___ ___ Python-bugs-list

[issue18192] Move imp.get_magic() to importlib

2013-06-14 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: The only argument I have about it is that if someone *does* want to use, it should be fairly easily discoverable. Also, since it's a concrete value, it seems a little weird that it's stashed in an abc. I suppose importlib.machinery.MAGIC is better than

[issue18192] Move imp.get_magic() to importlib

2013-06-14 Thread Brett Cannon
Brett Cannon added the comment: I'll put it into importlib.util.MAGIC. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18192 ___ ___

[issue18192] Move imp.get_magic() to importlib

2013-06-14 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Jun 14, 2013, at 07:53 PM, Brett Cannon wrote: I'll put it into importlib.util.MAGIC. +1 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18192 ___

[issue18192] Move imp.get_magic() to importlib

2013-06-14 Thread Brett Cannon
Changes by Brett Cannon br...@python.org: -- assignee: barry - brett.cannon ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18192 ___ ___

[issue18192] Move imp.get_magic() to importlib

2013-06-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5619bc2d8207 by Brett Cannon in branch 'default': Issue #18192: Introduce importlib.util.MAGIC_NUMBER and document the http://hg.python.org/cpython/rev/5619bc2d8207 -- nosy: +python-dev ___ Python

[issue18192] Move imp.get_magic() to importlib

2013-06-14 Thread Brett Cannon
Changes by Brett Cannon br...@python.org: -- resolution: - fixed stage: test needed - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18192 ___

[issue18192] Move imp.get_magic() to importlib

2013-06-12 Thread Brett Cannon
Brett Cannon added the comment: So what are your arguments to making it more accessible? The typical user won't need to use it so I don't know if it really requires being off of importlib directly like find_loader, import_module, or (eventually) reload (which for convenience-sake while at the

[issue18192] Move imp.get_magic() to importlib

2013-06-11 Thread Brett Cannon
New submission from Brett Cannon: As part of deprecating imp, need to move imp.get_magic() to importlib where it now belongs. Will be exposed as an attribute instead of a function, though. -- components: Library (Lib) messages: 190981 nosy: brett.cannon priority: normal severity:

[issue18192] Move imp.get_magic() to importlib

2013-06-11 Thread Brett Cannon
Brett Cannon added the comment: This could be an attribute on importlib.machinery.SourceLoader instead of an attribute in importlib.util. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18192

[issue18192] Move imp.get_magic() to importlib

2013-06-11 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Jun 11, 2013, at 08:44 PM, Brett Cannon wrote: As part of deprecating imp, need to move imp.get_magic() to importlib where it now belongs. Will be exposed as an attribute instead of a function, though. so, importlib.magic ? -- nosy: +barry

[issue18192] Move imp.get_magic() to importlib

2013-06-11 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I'd like to see it be more easily accessible. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18192 ___ ___

[issue18192] Move imp.get_magic() to importlib

2013-06-11 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18192 ___