[issue18216] gettext doesn't check MO versions

Aaron Hill added the comment: Awesome! Thanks! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue18216] gettext doesn't check MO versions

Antoine Pitrou added the comment: I've pushed it to 3.5 only. I don't think it's worth risking compatibility breakage in bugfix branches. Thank you for your contribution! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___

[issue18216] gettext doesn't check MO versions

Roundup Robot added the comment: New changeset 3b26a0983a3c by Antoine Pitrou in branch 'default': Issue #18216: gettext now raises an error when a .mo file has an unsupported major version number. Patch by Aaron Hill. https://hg.python.org/cpython/rev/3b26a0983a3c -- nosy: +python-dev

[issue18216] gettext doesn't check MO versions

Antoine Pitrou added the comment: Aaron, the patch looks fine, I'm going to commit it. -- versions: -Python 2.7, Python 3.4 ___ Python tracker ___ __

[issue18216] gettext doesn't check MO versions

Aaron Hill added the comment: Is there anything that needs to be changed? -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue18216] gettext doesn't check MO versions

Aaron Hill added the comment: I've added a second patch, which properly distinguishes between major and minor revisions, and updates the docs to account for the new behavior. -- ___ Python tracker

[issue18216] gettext doesn't check MO versions

Changes by Aaron Hill : Added file: http://bugs.python.org/file36958/gettext-mo-fixup.patch ___ Python tracker ___ ___ Python-bugs-list mailin

[issue18216] gettext doesn't check MO versions

Changes by Aaron Hill : Removed file: http://bugs.python.org/file36957/gettext-mo-fix-minor-version.patch ___ Python tracker ___ ___ Python-b

[issue18216] gettext doesn't check MO versions

Changes by Aaron Hill : Added file: http://bugs.python.org/file36957/gettext-mo-fix-minor-version.patch ___ Python tracker ___ ___ Python-bugs

[issue18216] gettext doesn't check MO versions

Aaron Hill added the comment: Okay, then. I'll just leave it out. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue18216] gettext doesn't check MO versions

Antoine Pitrou added the comment: The linked docs say: """an unexpected minor revision number means that the file can be read but will not reveal its full contents, when parsed by a program that supports only smaller minor revision numbers""". Unless there an important piece of contents that c

[issue18216] gettext doesn't check MO versions

Aaron Hill added the comment: Does anyone have any thoughts about throwing a warning for an unexpected minor revision? -- ___ Python tracker ___

[issue18216] gettext doesn't check MO versions

Aaron Hill added the comment: That sounds good. Should a warning be thrown for an unexpected minor revision? -- ___ Python tracker ___ ___

[issue18216] gettext doesn't check MO versions

Jakub Wilk added the comment: The patch hardcodes 5 as version number in the exception message. The specifiction also says that "an unexpected minor revision number means that the file can be read but will not reveal its full contents, when parsed by a program that supports only smaller minor

[issue18216] gettext doesn't check MO versions

Changes by Berker Peksag : -- nosy: +berker.peksag stage: -> patch review type: -> behavior versions: +Python 2.7, Python 3.4, Python 3.5 ___ Python tracker ___ ___

[issue18216] gettext doesn't check MO versions

Changes by Aaron Hill : -- keywords: +patch nosy: +Aaron1011 Added file: http://bugs.python.org/file36828/gettext-mo-version.patch ___ Python tracker ___

[issue18216] gettext doesn't check MO versions

Jakub Wilk added the comment: I believe so, yes. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue18216] gettext doesn't check MO versions

Mark Lawrence added the comment: @Jakub does this apply to all Python versions and OSes? -- nosy: +BreamoreBoy, loewis ___ Python tracker ___

[issue18216] gettext doesn't check MO versions

New submission from Jakub Wilk: The MO file format specification[0] reads: "A program seeing an unexpected major revision number should stop reading the MO file entirely" But Python doesn't pay attention to versions at all. As a test-case I attached a MO file with a bogus major revision number.