[issue18236] str.isspace should use the Unicode White_Space property

Change by Greg Price : -- keywords: +patch pull_requests: +15849 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/16254 ___ Python tracker

[issue18236] str.isspace should use the Unicode White_Space property

Greg Price added the comment: > I've gone and made a patch for this change Update: * The preparatory changes in #37760 are now almost all merged; GH-15265 is the one piece remaining, and I'd be grateful for a review. It's a generally straightforward and boring change that converts the main

[issue18236] str.isspace should use the Unicode White_Space property

Greg Price added the comment: Good question! With the patch: >>> import re >>> re.match(r'\s', '\x1e') >>> In other words, the definition of the regexp r'\s' follows along. Good to know. -- ___ Python tracker

[issue18236] str.isspace should use the Unicode White_Space property

Ma Lin added the comment: Greg, could you try this code after your patch? >>> import re >>> re.match(r'\s', '\x1e') # <- before patch -- nosy: +Ma Lin ___ Python tracker

[issue18236] str.isspace should use the Unicode White_Space property

Greg Price added the comment: I've gone and made a patch for this change: https://github.com/gnprice/cpython/commit/7dab9d879 Most of the work happens in the script Tools/unicode/makeunicode.py , and along the way I made several changes there that I found made it somewhat nicer to work on,

[issue18236] str.isspace should use the Unicode White_Space property

Martin Panter added the comment: As uncovered in Issue 12855, str.splitlines() currently considers the FS, GS and RS (1C–1E), but not the US (1F), to be line breaks. It might be surprising if these are no longer considered white space but are still considered line breaks. -- nosy:

[issue18236] str.isspace should use the Unicode White_Space property

Changes by Alexander Belopolsky alexander.belopol...@gmail.com: -- assignee: belopolsky - keywords: -needs review, patch stage: commit review - needs patch versions: +Python 3.5 -Python 3.3, Python 3.4 ___ Python tracker rep...@bugs.python.org

[issue18236] str.isspace should use the Unicode White_Space property

Alexander Belopolsky added the comment: For future reference, the code discussed above is in the following portion of the patch: -#define Py_UNICODE_ISSPACE(ch) \ -((ch) 128U ? _Py_ascii_whitespace[(ch)] : _PyUnicode_IsWhitespace(ch)) +#define Py_UNICODE_ISSPACE(ch)

[issue18236] str.isspace should use the Unicode White_Space property

Changes by R. David Murray rdmur...@bitdance.com: -- nosy: +r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18236 ___ ___

[issue18236] str.isspace should use the Unicode White_Space property

Changes by Serhiy Storchaka storch...@gmail.com: -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18236 ___ ___

[issue18236] str.isspace should use the Unicode White_Space property

Alexander Belopolsky added the comment: I have updated the title to focus this issue on the behavior of str.isspace(). I'll pick up remaining int/float issues in #10581. -- assignee: - belopolsky title: int() and float() do not accept strings with trailing separators - str.isspace

[issue18236] str.isspace should use the Unicode White_Space property

Changes by Alexander Belopolsky alexander.belopol...@gmail.com: Added file: http://bugs.python.org/file30679/3ed5bb7fcee9.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18236 ___

[issue18236] str.isspace should use the Unicode White_Space property

Changes by Alexander Belopolsky alexander.belopol...@gmail.com: Removed file: http://bugs.python.org/file30677/5c934626d44d.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18236 ___

[issue18236] str.isspace should use the Unicode White_Space property

Changes by Alexander Belopolsky alexander.belopol...@gmail.com: Added file: http://bugs.python.org/file30680/42973dfea391.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18236 ___

[issue18236] str.isspace should use the Unicode White_Space property

Changes by Alexander Belopolsky alexander.belopol...@gmail.com: Removed file: http://bugs.python.org/file30679/3ed5bb7fcee9.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18236 ___

[issue18236] str.isspace should use the Unicode White_Space property

Alexander Belopolsky added the comment: I would like someone review this change: https://bitbucket.org/alexander_belopolsky/cpython/commits/92c187025d0a8a989d9f81f2cb4c96f4eecb81cb?at=issue-18236 The patch can go in without this optimization, but I think this is the right first step towards

[issue18236] str.isspace should use the Unicode White_Space property

Martin v. Löwis added the comment: -1 on that patch. It's using trickery to implement the test, and it's not clear that it is actually as efficient as the previous version. The previous version was explicitly modified to use a table lookup for performance reasons. I'd be fine with not