[issue18368] PyOS_StdioReadline() leaks memory when realloc() fails

STINNER Victor added the comment: New changeset d9c6564f90ead067c2e288f01825684821b7a129 by Victor Stinner (stratakis) in branch '2.7': [2.7] bpo-18368: Fix memory leaks in PyOS_StdioReadline() when realloc() fails (GH-12334) https://github.com/python/cpython/commit/d9c6564f90ead067c2e288f01

[issue18368] PyOS_StdioReadline() leaks memory when realloc() fails

Change by Charalampos Stratakis : -- pull_requests: +12305 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue18368] PyOS_StdioReadline() leaks memory when realloc() fails

Changes by Christian Heimes : -- status: pending -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue18368] PyOS_StdioReadline() leaks memory when realloc() fails

Christian Heimes added the comment: Serhiy: Thanks for the review Kristján: Yes, it's enough to check for incr > INT_MAX. The buffer size is incremented to a value of <= (2*n)+2 in each round. The start value is 100. The loop is terminated once the buffer size reaches INT_MAX-2. -- re

[issue18368] PyOS_StdioReadline() leaks memory when realloc() fails

Roundup Robot added the comment: New changeset 5859a3ec5b7e by Christian Heimes in branch '3.3': Issue #18368: PyOS_StdioReadline() no longer leaks memory when realloc() fails. http://hg.python.org/cpython/rev/5859a3ec5b7e New changeset 6dbc4d6ff31e by Christian Heimes in branch 'default': Issue

[issue18368] PyOS_StdioReadline() leaks memory when realloc() fails

Serhiy Storchaka added the comment: The patch can be a little simplified (the "else" keyword is redundant), but in general it LGTM. Let's push. -- ___ Python tracker ___ ___

[issue18368] PyOS_StdioReadline() leaks memory when realloc() fails

Kristján Valur Jónsson added the comment: Is it sufficient to check incr > INT_MAX to guard against overflow? -- ___ Python tracker ___ __

[issue18368] PyOS_StdioReadline() leaks memory when realloc() fails

Serhiy Storchaka added the comment: A similar issue: #14909. -- nosy: +kristjan.jonsson, serhiy.storchaka ___ Python tracker ___ ___ P

[issue18368] PyOS_StdioReadline() leaks memory when realloc() fails

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue18368] PyOS_StdioReadline() leaks memory when realloc() fails

New submission from Christian Heimes: PyOS_StdioReadline() contains code such as: p = (char *)PyMem_REALLOC(p, n + incr); The code looses its pointer to p when realloc fails and has no chance to free the memory in p. Also the code sets PyExc_OverflowError when incr > INT_MAX but it doesn't