[issue18530] posixpath.ismount performs extra lstat calls

2014-08-25 Thread Alex Gaynor
Alex Gaynor added the comment: Ok, this was landed, 3.3 is no longer open so closing this. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18530

[issue18530] posixpath.ismount performs extra lstat calls

2014-08-25 Thread Berker Peksag
Changes by Berker Peksag berker.pek...@gmail.com: -- stage: patch review - resolved ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18530 ___ ___

[issue18530] posixpath.ismount performs extra lstat calls

2013-07-22 Thread Alex Gaynor
New submission from Alex Gaynor: Right now it calls islink(), which does an lstat, and then does its own lstat on the same path. This can be optimized by inlining the body of islink and reusing the stat result. (This has been identified as an actual issue in openstack-swift

[issue18530] posixpath.ismount performs extra lstat calls

2013-07-22 Thread Alex Gaynor
Alex Gaynor added the comment: Attached is a simple first pass at a diff against 2.7, shoudl be easy to port it to default. -- keywords: +patch Added file: http://bugs.python.org/file31010/ismount.diff ___ Python tracker rep...@bugs.python.org

[issue18530] posixpath.ismount performs extra lstat calls

2013-07-22 Thread Alex Gaynor
Alex Gaynor added the comment: Addresses the review comments: returns to catching all oserrors -- Added file: http://bugs.python.org/file31011/ismount.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18530

[issue18530] posixpath.ismount performs extra lstat calls

2013-07-22 Thread Alex Gaynor
Alex Gaynor added the comment: Attached patch is against default. I don't have my ssh keys set up for this machine, so if someone else could land I'd be appreciative :) (Not sure if this qualifies for a backport) -- Added file: http://bugs.python.org/file31012/ismount-3k.diff

[issue18530] posixpath.ismount performs extra lstat calls

2013-07-22 Thread Christian Heimes
Christian Heimes added the comment: LGTM -- nosy: +christian.heimes stage: - patch review type: - resource usage versions: +Python 3.3, Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18530

[issue18530] posixpath.ismount performs extra lstat calls

2013-07-22 Thread Brian Curtin
Brian Curtin added the comment: Benjamin probably has the final say on backporting this to 2.7. I'm doing the 3.3/default commit right now. -- nosy: +brian.curtin ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18530

[issue18530] posixpath.ismount performs extra lstat calls

2013-07-22 Thread Brian Curtin
Brian Curtin added the comment: ^That takes care of default. I misspoke in an earlier comment about 3.3 - that should probably be determined by that RM (Georg?) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18530

[issue18530] posixpath.ismount performs extra lstat calls

2013-07-22 Thread Roundup Robot
Roundup Robot added the comment: New changeset 240adc564539 by Brian Curtin in branch 'default': Fix #18530. Remove extra stat call from posixpath.ismount http://hg.python.org/cpython/rev/240adc564539 -- nosy: +python-dev ___ Python tracker