[issue18592] Idle: test SearchDialogBase.py
Roundup Robot added the comment: New changeset b6c5719e0f4e by Terry Jan Reedy in branch '2.7': Issue #18592: Method return signature changes made to SearchDialogBase for http://hg.python.org/cpython/rev/b6c5719e0f4e New changeset 407110796b16 by Terry Jan Reedy in branch '3.4': Issue #18592: Method return signature changes made to SearchDialogBase for http://hg.python.org/cpython/rev/407110796b16 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18592 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18592] Idle: test SearchDialogBase.py
Saimadhav Heblikar added the comment: A bug introduced by 91491:a0e8f2d882a3. Opening Find-in-files gives the following error Exception in Tkinter callback Traceback (most recent call last): File /home/saimadhav/dev/34-cpython/Lib/tkinter/__init__.py, line 1487, in __call__ . . SNIPPED . . self.tk = master.tk AttributeError: 'tuple' object has no attribute 'tk' -- Added file: http://bugs.python.org/file35937/grepdialog_bug.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18592 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18592] Idle: test SearchDialogBase.py
Roundup Robot added the comment: New changeset 30a75f75a4d4 by Terry Jan Reedy in branch '2.7': Issue #18592: Make unittest for SearchDialogBase work on all tk versions. http://hg.python.org/cpython/rev/30a75f75a4d4 New changeset 91546aa91cee by Terry Jan Reedy in branch '3.4': Issue #18592: Make unittest for SearchDialogBase work on all tk versions. http://hg.python.org/cpython/rev/91546aa91cee -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18592 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18592] Idle: test SearchDialogBase.py
Saimadhav Heblikar added the comment: Hi, test_make_entry seems to be failing (for eg: http://buildbot.python.org/all/builders/AMD64%20Debian%20root%203.4/builds/306/steps/test/logs/stdio and http://buildbot.python.org/all/builders/AMD64%20Debian%20root%203.x/builds/911/steps/test/logs/stdio) == FAIL: test_make_entry (idlelib.idle_test.test_searchdialogbase.SearchDialogBaseTest) -- Traceback (most recent call last): File /root/buildarea/3.x.angelico-debian-amd64/build/Lib/idlelib/idle_test/test_searchdialogbase.py, line 83, in test_make_entry equal(egi['row'], 0) AssertionError: '0' != 0 -- Ran 128 tests in 0.779s FAILED (failures=1) test test_idle failed Attach patch fixes it in a straight forward way. -- nosy: +sahutd Added file: http://bugs.python.org/file35883/issue18592-fix.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18592 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18592] Idle: test SearchDialogBase.py
Terry J. Reedy added the comment: Serhiy: we are having a problem with tkinter sometimes reporting boolean vars as '0' and '1' versus 0 and 1. As I remember, you pushed a patch about this in the last year, probably before 3.4 came out, but after last August. Am I correct? If so, do you remember the issue? Saimadhav: changing expected values *back* to '0'/'1', as in Phil's original patch, will make the test fail on all the systems (including all stable buildbots) that *do* return 0/1. After Serhiy's fix, I had to switch to 0/1 for 3.4/5 to make the tests pass again, after the change made them fail. Notice that the 2.7 version, pushed on 6/30 also, still has '0', '1'. The interesting question is why the Debian 3.4 system is different? Why is it acting like 2.7? Serhiy, do you have any idea? I am also puzzled why the corresponding text_tcl or _tk did not fail, as I presume there is a text for the change. -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18592 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18592] Idle: test SearchDialogBase.py
Saimadhav Heblikar added the comment: The interesting question is why the Debian 3.4 system is different? That is what caused me to notice the issue. I ran the IDLE test suite on my pc(debian 7) and it failed, while most buildbots were green. Why is it acting like 2.7? Serhiy, do you have any idea? 2.7 with '0'/'1' is passing. (I am removing the patch as this issue has a background that I was not aware of.) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18592 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18592] Idle: test SearchDialogBase.py
Changes by Saimadhav Heblikar saimadhavhebli...@gmail.com: Removed file: http://bugs.python.org/file35883/issue18592-fix.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18592 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18592] Idle: test SearchDialogBase.py
Terry J. Reedy added the comment:
What micro tk version? as in
t = tk.Tk()
t.tk.call('info', 'patchlevel')
'8.5.15'
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18592
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18592] Idle: test SearchDialogBase.py
Serhiy Storchaka added the comment: I pushed a patch which fixed Text.debug(). This is not related to this issue. grid_info() values are depend on Tcl/Tk version. When 8.6 strings are always returned (except the 'in' key which is special case), when = 8.6 values can be integers or even tuples. I introduced the AbstractWidgetTest._str() method to convert expected value in widget tests. In these tests you can just write equal(int(egi['row']), 0). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18592 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18592] Idle: test SearchDialogBase.py
Terry J. Reedy added the comment: Ah, Debian must not be using 8.6. Thanks for both the clarification and how to fix. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18592 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18592] Idle: test SearchDialogBase.py
Roundup Robot added the comment: New changeset 2b7a4cbed2a0 by Terry Jan Reedy in branch '2.7': Issue #18592: Add unittests for SearchDialogBase. Patch by Phil Webster. http://hg.python.org/cpython/rev/2b7a4cbed2a0 New changeset a0e8f2d882a3 by Terry Jan Reedy in branch '3.4': Issue #18592: Add unittests for SearchDialogBase. Patch by Phil Webster. http://hg.python.org/cpython/rev/a0e8f2d882a3 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18592 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18592] Idle: test SearchDialogBase.py
Roundup Robot added the comment: New changeset a7f943a13f7f by Terry Jan Reedy in branch '2.7': Issue #18592: Refactor 2 SearchDialogBase.create_(option/other)_buttons methods http://hg.python.org/cpython/rev/a7f943a13f7f New changeset 86c26ff25207 by Terry Jan Reedy in branch '3.4': Issue #18592: Refactor 2 SearchDialogBase.create_(option/other)_buttons methods http://hg.python.org/cpython/rev/86c26ff25207 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18592 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18592] Idle: test SearchDialogBase.py
Changes by Terry J. Reedy tjre...@udel.edu: -- resolution: - fixed stage: commit review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18592 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18592] Idle: test SearchDialogBase.py
Terry J. Reedy added the comment: The warning was due to absence of def self.root. Attached is close to what will commit. -- stage: needs patch - commit review Added file: http://bugs.python.org/file35784/test-search-sdb-18592-34.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18592 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18592] Idle: test SearchDialogBase.py
Roundup Robot added the comment: New changeset 752439a6bdd9 by Terry Jan Reedy in branch '2.7': Issue #18592: For idlelib.SearchDialogBase, edit and add docstrings, http://hg.python.org/cpython/rev/752439a6bdd9 New changeset ed60a73e1c82 by Terry Jan Reedy in branch '3.4': Issue #18592: For idlelib.SearchDialogBase, edit and add docstrings, http://hg.python.org/cpython/rev/ed60a73e1c82 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18592 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18592] Idle: test SearchDialogBase.py
Terry J. Reedy added the comment: I am getting the ttk Themechanges warning. The test needs to use an search engine altered as with test_searchengine. I will work on that next. -- stage: patch review - needs patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18592 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18592] Idle: test SearchDialogBase.py
Changes by Terry J. Reedy tjre...@udel.edu: -- title: IDLE: Unit test for SearchDialogBase.py - Idle: test SearchDialogBase.py versions: +Python 3.5 -Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18592 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
