[issue18610] wsgiref.validate expects wsgi.input read to give exactly one arg

[Cheryl Sabella]

Change by Cheryl Sabella :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8 -Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18610] wsgiref.validate expects wsgi.input read to give exactly one arg

[Cheryl Sabella]

Cheryl Sabella  added the comment:


New changeset f8716c88f13f035c126fc1db499ae0ea309c7ece by Cheryl Sabella in 
branch 'master':
bpo-18610: Update wsgiref.validate docstring for wsgi.input read() (GH-11663)
https://github.com/python/cpython/commit/f8716c88f13f035c126fc1db499ae0ea309c7ece


--
nosy: +cheryl.sabella

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18610] wsgiref.validate expects wsgi.input read to give exactly one arg

[Cheryl Sabella]

Change by Cheryl Sabella :


--
pull_requests:  -11469

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18610] wsgiref.validate expects wsgi.input read to give exactly one arg

[Cheryl Sabella]

Change by Cheryl Sabella :


--
pull_requests:  -11468

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18610] wsgiref.validate expects wsgi.input read to give exactly one arg

[Cheryl Sabella]

Change by Cheryl Sabella :


--
pull_requests: +11467, 11468, 11469
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18610] wsgiref.validate expects wsgi.input read to give exactly one arg

[Cheryl Sabella]

Change by Cheryl Sabella :


--
pull_requests: +11467, 11468
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18610] wsgiref.validate expects wsgi.input read to give exactly one arg

[Cheryl Sabella]

Change by Cheryl Sabella :


--
pull_requests: +11467
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18610] wsgiref.validate expects wsgi.input read to give exactly one arg

[PJ Eby]

PJ Eby added the comment:

This area of the spec is different between 333 and  precisely to clarify 
this point, without technically changing conformance requirements.  PEP 333 was 
supposed to require the app to supply an argument, while PEP  was changed 
to encourage the server to allow the app to omit it.

It's an annoying grey area in the spec itself, but not at all a grey area for 
for the validation tool, which is supposed to validate the strictest 
interpretation of the spec.  A conformant server is allowed to not work with a 
missing argument, so it's a bad idea for your app to omit it if you want to run 
on all conformant servers.  (And this is entirely independent of whether it's a 
good idea to read the entire stream in the first place.)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18610] wsgiref.validate expects wsgi.input read to give exactly one arg

[Robin Schoonover]

Robin Schoonover added the comment:

I'm not sure I follow, as it has little to say on whether the application's 
expected behavior here, and only a recommendation that the server allow it.  
But, it also defers to the "Python Standard Library", which does have an 
opinion.  I feel that (in hindsight) the exact behavior of each method should 
have been specified in full.

*However*, even if I differ on the reading of the spec, on general principle 
(and this has changed since I first wrote the issue) I agree that the 
application should not be omitting it anyway, because reading the entire 
response at once without checking the content length is dangerous.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18610] wsgiref.validate expects wsgi.input read to give exactly one arg

[PJ Eby]

PJ Eby added the comment:

This is a misreading of the spec.  The read() method is defined as taking 
exactly one parameter.  The server *should* support it being optional, but the 
app invoking it without an argument is not compliant, and wsgiref.validate is 
validating that the *app* performs according to spec, not the server.

Therefore, the documentation is what's in error, not the code.

--
assignee:  -> docs@python
components: +Documentation -Library (Lib)
nosy: +docs@python
stage: patch review -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18610] wsgiref.validate expects wsgi.input read to give exactly one arg

[Berker Peksag]

Berker Peksag added the comment:

The change was suggested before PEP  in issue 4718 (see msg78292), but PEP 
 says:

A server should allow read() to be called without an argument, and return 
the remainder of the client's input stream.

https://www.python.org/dev/peps/pep-/#input-and-error-streams

I couldn't find any objection at 
https://mail.python.org/pipermail/web-sig/2010-September/004655.html

--
nosy: +berker.peksag
stage:  -> patch review
versions: +Python 3.4, Python 3.5 -Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18610] wsgiref.validate expects wsgi.input read to give exactly one arg

[Robin Schoonover]

Changes by Robin Schoonover :


--
nosy: +pje

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18610] wsgiref.validate expects wsgi.input read to give exactly one arg

[Robin Schoonover]

Changes by Robin Schoonover :


--
title: wsgiref.validator expects wsgi.input read to give exactly one arg -> 
wsgiref.validate expects wsgi.input read to give exactly one arg

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com