[issue18668] Properly document setting m_size in PyModuleDef

2013-08-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset f55ba27776d4 by Eli Bendersky in branch '3.3': Issue #18668: Further clarify m_size setting for non-negative values http://hg.python.org/cpython/rev/f55ba27776d4 New changeset d43435e82e21 by Eli Bendersky in branch 'default': Issue #18668: Further

[issue18668] Properly document setting m_size in PyModuleDef

2013-08-08 Thread Eli Bendersky
Eli Bendersky added the comment: Nick, you're right - m_size=0 is a valid value. How about the attached patch? -- Added file: http://bugs.python.org/file31199/issue18668.msize-fix.patch ___ Python tracker rep...@bugs.python.org

[issue18668] Properly document setting m_size in PyModuleDef

2013-08-08 Thread Nick Coghlan
Nick Coghlan added the comment: Looks good to me. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18668 ___ ___ Python-bugs-list mailing list

[issue18668] Properly document setting m_size in PyModuleDef

2013-08-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset 698fd628b001 by Eli Bendersky in branch '3.3': Issue #18668: Properly document setting m_size in PyModuleDef http://hg.python.org/cpython/rev/698fd628b001 New changeset 9877c25d9556 by Eli Bendersky in branch 'default': Closing #18668: Properly

[issue18668] Properly document setting m_size in PyModuleDef

2013-08-07 Thread Eli Bendersky
Eli Bendersky added the comment: Thanks for the review! -- resolution: fixed - stage: committed/rejected - needs patch status: closed - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18668

[issue18668] Properly document setting m_size in PyModuleDef

2013-08-07 Thread Eli Bendersky
Changes by Eli Bendersky eli...@gmail.com: -- resolution: - fixed stage: needs patch - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18668 ___

[issue18668] Properly document setting m_size in PyModuleDef

2013-08-07 Thread Nick Coghlan
Nick Coghlan added the comment: I thought setting m_size to zero was for No per module state, but reinitialization is fine? Does that not work? (I haven't actually tried it) -- ___ Python tracker rep...@bugs.python.org

[issue18668] Properly document setting m_size in PyModuleDef

2013-08-06 Thread Eli Bendersky
New submission from Eli Bendersky: docs.python.org/dev/c-api/module.html Currently doesn't say much about m_size, except that setting it to -1 means no memory needed. m_size == -1 has a much more important use that is not documented: it signals the import machinery that the module should not

[issue18668] Properly document setting m_size in PyModuleDef

2013-08-06 Thread Eli Bendersky
Changes by Eli Bendersky eli...@gmail.com: -- nosy: +loewis ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18668 ___ ___ Python-bugs-list mailing

[issue18668] Properly document setting m_size in PyModuleDef

2013-08-06 Thread Eli Bendersky
Eli Bendersky added the comment: Here's a documentation patch generated for 3.3 -- keywords: +patch Added file: http://bugs.python.org/file31174/issue18668.doc.1.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18668

[issue18668] Properly document setting m_size in PyModuleDef

2013-08-06 Thread Antoine Pitrou
Antoine Pitrou added the comment: Looks good to me, thanks. -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18668 ___ ___