Serhiy Storchaka added the comment:
I forgot to merge branches? Thanks Ned.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18702
___
___
Serhiy Storchaka added the comment:
Related issues: issue19492 and issue19493.
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18702
Roundup Robot added the comment:
New changeset 1feeeb8992f8 by Serhiy Storchaka in branch '3.3':
Issue #18702: All skipped tests now reported as skipped.
http://hg.python.org/cpython/rev/1feeeb8992f8
New changeset 09105051b9f4 by Serhiy Storchaka in branch 'default':
Issue #18702: All skipped
Roundup Robot added the comment:
New changeset 2d330f7908e7 by Serhiy Storchaka in branch '2.7':
Issue #18702: All skipped tests now reported as skipped.
http://hg.python.org/cpython/rev/2d330f7908e7
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 0d8f0526813f by Serhiy Storchaka in branch '2.7':
Fix test_os (issue #18702).
http://hg.python.org/cpython/rev/0d8f0526813f
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18702
Roundup Robot added the comment:
New changeset a699550bc73b by Ned Deily in branch 'default':
Issue #18702 null merge
http://hg.python.org/cpython/rev/a699550bc73b
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18702
Serhiy Storchaka added the comment:
Patch is rebased to tip.
--
Added file: http://bugs.python.org/file32245/skip_tests_3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18702
___
Ned Deily added the comment:
I took a quick look at the revised patch. Clearly, it's too big to review at a
detailed level. I tried the approach of running two complete verbose regrtest
runs (-m test -v -uall), before and after the patch, and diffing the results in
a smart diff app. Again,
Changes by Zachary Ware zachary.w...@gmail.com:
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18702
___
___
Python-bugs-list
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18702
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
I'm not sure I understand you Rietveld comment right Terry.
We can get rid of _have_ssl (this is implementation detail and shouldn't be
required) and just try import ssl.
try:
import ssl
except ImportError:
ssl = None
If ssl is not None but
Terry J. Reedy added the comment:
You changed NNTP_CLASS = nntplib.NNTP_SSL, which could potentially fail, to
NNTP_CLASS = getattr(nntplib, 'NNTP_SSL', None), which cannot fail. Since
that was the only thing that previously could fail, the change leaves nothing
that can fail, so the test is
Serhiy Storchaka added the comment:
You changed NNTP_CLASS = nntplib.NNTP_SSL, which could potentially fail, to
NNTP_CLASS = getattr(nntplib, 'NNTP_SSL', None), which cannot fail. Since
that was the only thing that previously could fail, the change leaves nothing
that can fail, so the
Terry J. Reedy added the comment:
My original suggestion was to put the possibly failing assignment inside
@classmethod
def setUpClass:
NNTP_CLASS = nntplib.NNTP_SSL
so that failure of the assignment would be be reported, but not affect import.
--
Serhiy Storchaka added the comment:
Actually you should call parent's setUpClass at the and of declared setUpClass.
Therefore you need 4 nontrivial lines instead of 1. The test will fail in
setUpClass() in any case because parent's setUpClass() uses NNTP_CLASS. There
are no behavior
Serhiy Storchaka added the comment:
Which one is the preferred way to go? requires or test needs or needs?
Or it does not matter?
I used the wording which used in other skips in the same file or in similar
skips in other files. If it matters I will correct messages.
Which one is the
Terry J. Reedy added the comment:
The patch applies cleanly on my 3.4 Win 7, fresh debug build. Somewhat
fortuitously, as it turns out, I have not downloaded the files needed for ssl
support. For each modified file, I ran
python_d -m test -v test_xxx
test test_nntplib crashed -- Traceback
Serhiy Storchaka added the comment:
Thank you Ezio and Terry for review. Here is updated patch. Problems with class
initialization solved. I have made a lot of other changes especially in
test_os.py and test_posix.py.
--
Added file: http://bugs.python.org/file31233/skip_tests_2.patch
Terry J. Reedy added the comment:
Applies and runs (with text_posix entirely skipped).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18702
___
Vajrasky Kok added the comment:
I read the patch. It looks good.
Anyway, I have two questions:
1. I saw 3 variants of writing description for skipping test descriptor:
requires os.mkfifo
test needs socket.inet_pton()
needs os.read
Which one is the preferred way to go? requires or test
New submission from Serhiy Storchaka:
Some tests in Python testsuite are silently skipped if requirements is not
satisfied. The proposed patch adds explicit skipUnless() and raise
SkipTest() so that these tests now reported as skipped.
I.e. the code like
if not condition:
def
21 matches
Mail list logo
