[issue18722] Remove uses of the register keyword

Serhiy Storchaka added the comment: Agree that comments like /* Help allocation */ are confused and misleading. -- ___ Python tracker ___

[issue18722] Remove uses of the register keyword

Martin Panter added the comment: I did a review of some of the changes in . In particular, there are a couple of comments /* Help register allocation */ which were mangled to /* Help allocation */. But it is not clear if the leftover variable

[issue18722] Remove uses of the register keyword

Mark Dickinson added the comment: +1 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18722 ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18722] Remove uses of the register keyword

Serhiy Storchaka added the comment: have exactly the same size Binaries contain paddings. although their md5 hashes differ Timestamps. I'm interesting if someone builds CPython with more simple compilers (i.e. PCC [1]). [1] http://en.wikipedia.org/wiki/Portable_C_Compiler --

[issue18722] Remove uses of the register keyword

Antoine Pitrou added the comment: Serhiy Storchaka added the comment: have exactly the same size Binaries contain paddings. I used the size command, which gives you the exact size of the various sections (rather than the physical file size). --

[issue18722] Remove uses of the register keyword

Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18722 ___

[issue18722] Remove uses of the register keyword

Raymond Hettinger added the comment: +1 The era of register has passed. -- nosy: +rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18722 ___

[issue18722] Remove uses of the register keyword

STINNER Victor added the comment: Is PCC used by any Linux or BSD distro? BSD prefers Clang. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18722 ___

[issue18722] Remove uses of the register keyword

Roundup Robot added the comment: New changeset e7f6cef7a4cc by Antoine Pitrou in branch 'default': Issue #18722: Remove uses of the register keyword in C code. http://hg.python.org/cpython/rev/e7f6cef7a4cc -- nosy: +python-dev ___ Python tracker

[issue18722] Remove uses of the register keyword

Antoine Pitrou added the comment: Committed. I don't think clang or MSVC would bother more than gcc does. -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org

[issue18722] Remove uses of the register keyword

New submission from Antoine Pitrou: Attached patch removes all uses of the C register keyword in the CPython sources. -- components: Interpreter Core files: remove_register.patch keywords: patch messages: 195024 nosy: pitrou priority: low severity: normal stage: patch review status:

[issue18722] Remove uses of the register keyword

Antoine Pitrou added the comment: The benchmark suite doesn't show any significant speedup or slowdown generally: Report on Linux fsol 3.8.0-27-generic #40-Ubuntu SMP Tue Jul 9 00:17:05 UTC 2013 x86_64 x86_64 Total CPU cores: 4 ### django_v2 ### Min: 0.672909 - 0.659464: 1.02x faster Avg:

[issue18722] Remove uses of the register keyword

Changes by Antoine Pitrou pit...@free.fr: -- nosy: +mark.dickinson, skrah ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18722 ___ ___

[issue18722] Remove uses of the register keyword

Antoine Pitrou added the comment: (amusingly, the two Python executables generated by gcc - with or without register - have exactly the same size, although their md5 hashes differ) -- ___ Python tracker rep...@bugs.python.org

[issue18722] Remove uses of the register keyword

STINNER Victor added the comment: +1 for removal of the register keyword. I hope that nowadays, no compiler needs register hint to be able to optimize correctly a function. GCC knows better than me which variables must be optimized. -- nosy: +haypo