[issue18904] Unnecessary test in file descriptor inheritance test
Changes by STINNER Victor victor.stin...@gmail.com: -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18904 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18904] Unnecessary test in file descriptor inheritance test
Roundup Robot added the comment: New changeset b13cec63b495 by Victor Stinner in branch 'default': Issue #18904: Improve os.get/set_inheritable() tests http://hg.python.org/cpython/rev/b13cec63b495 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18904 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18904] Unnecessary test in file descriptor inheritance test
STINNER Victor added the comment: Thanks for the report and the patch. I removed the duplicate test, but I also added new tests using fcntl and FD_CLOEXEC. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18904 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18904] Unnecessary test in file descriptor inheritance test
Roundup Robot added the comment: New changeset b7f6f6f59e91 by Victor Stinner in branch 'default': Issue #18904: test_socket: add inheritance tests using fcntl and FD_CLOEXEC http://hg.python.org/cpython/rev/b7f6f6f59e91 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18904 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18904] Unnecessary test in file descriptor inheritance test
Roundup Robot added the comment: New changeset aea58e1cae75 by Victor Stinner in branch 'default': Issue #18904: test_os and test_socket use unittest.skipIf() to check if fcntl http://hg.python.org/cpython/rev/aea58e1cae75 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18904 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18904] Unnecessary test in file descriptor inheritance test
Changes by Ezio Melotti ezio.melo...@gmail.com: -- assignee: - haypo stage: - patch review type: - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18904 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18904] Unnecessary test in file descriptor inheritance test
Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18904 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18904] Unnecessary test in file descriptor inheritance test
New submission from Vajrasky Kok: In Lib/test/test_os.py in class FDInheritanceTests, we have an unnecessary test, which is test_set_inheritable. What test_set_inheritable tests is already being covered by test_get_inheritable. Also, I think test_get_inheritable should be renamed to test_set_inheritable. Please, see the patch to see what I mean. -- components: Tests files: remove_unnecessary_test_fd_inheritable.patch keywords: patch messages: 196768 nosy: haypo, vajrasky priority: normal severity: normal status: open title: Unnecessary test in file descriptor inheritance test versions: Python 3.4 Added file: http://bugs.python.org/file31553/remove_unnecessary_test_fd_inheritable.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18904 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
