[issue18919] Unify audio modules tests

2013-10-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you David. Fixed in issue19276. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue18919] Unify audio modules tests

2013-10-16 Thread R. David Murray
R. David Murray added the comment: It looks like test_wave is still failing on PPC64 PowerLinux: http://buildbot.python.org/all/builders/PPC64%20PowerLinux%203.x/builds/850/steps/test/logs/stdio -- ___ Python tracker

[issue18919] Unify audio modules tests

2013-10-14 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue18919] Unify audio modules tests

2013-10-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset de1f62a55648 by Serhiy Storchaka in branch '2.7': Issue #18919: Add test/audiodata to LIBSUBDIRS. http://hg.python.org/cpython/rev/de1f62a55648 New changeset 865bab7387f2 by Serhiy Storchaka in branch '3.3': Issue #18919: Add test/audiodata to LIBSU

[issue18919] Unify audio modules tests

2013-10-14 Thread Ned Deily
Ned Deily added the comment: The new tests fail when run from an installed Python. You also need to add all of the new test directories to LIBSUBDIRS for the libinstall target in Makefile.pre.in. -- nosy: +ned.deily ___ Python tracker

[issue18919] Unify audio modules tests

2013-10-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > In 3.x we removed that check. But I wonder if that was wise :) (We did it > for technical reasons when adding other features to regrtest). Actually the checks left, but there was no check for warning message. Now they are added. > Some new (I assume) Re

[issue18919] Unify audio modules tests

2013-10-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset fd7752db1e54 by Serhiy Storchaka in branch '2.7': Issue #18919: Fixed resource leaks in audio tests. http://hg.python.org/cpython/rev/fd7752db1e54 New changeset 2850fc02f324 by Serhiy Storchaka in branch '3.3': Issue #18919: Fixed resource leaks in

[issue18919] Unify audio modules tests

2013-10-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset 164a60cce934 by Serhiy Storchaka in branch '2.7': Issue #18919: Catch and check warnings in the aifc module tests. http://hg.python.org/cpython/rev/164a60cce934 New changeset 9eecd00ffc28 by Serhiy Storchaka in branch '3.3': Issue #18919: Check warn

[issue18919] Unify audio modules tests

2013-10-14 Thread Georg Brandl
Georg Brandl added the comment: Some new (I assume) ResourceWarnings from test_wave: /home/gbr/devel/python/Lib/unittest/case.py:571: ResourceWarning: unclosed file <_io.BufferedWriter name='@test_1974_tmp'> testMethod() /home/gbr/devel/python/Lib/chunk.py:61: ResourceWarning: unclosed file

[issue18919] Unify audio modules tests

2013-10-14 Thread R. David Murray
R. David Murray added the comment: In 2.7 unexpected output is a test failure, yes. In 3.x we removed that check. But I wonder if that was wise :) (We did it for technical reasons when adding other features to regrtest). Yes, using captured_stdout and checking for the expected warnings would

[issue18919] Unify audio modules tests

2013-10-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Is unexpected output considered as test failing? The aifc module uses bare print to output these "warnings" to stdout. Here is a patch which uses captured_stdout(). -- Added file: http://bugs.python.org/file32109/test_aifc_capture_warnings.patch ___

[issue18919] Unify audio modules tests

2013-10-14 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- stage: committed/rejected -> patch review status: closed -> open ___ Python tracker ___ ___ Python-bu

[issue18919] Unify audio modules tests

2013-10-14 Thread koobs
koobs added the comment: Tests fail for 2.7 on the koobs-freebsd9 and koobs-freebsd10 buildbots since a9f967c8d002db364021a5fb1c9926a27029e849 Taking a snapshot of the output here for reference: test_aifc test test_aifc produced unexpected output: **

[issue18919] Unify audio modules tests

2013-10-13 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue18919] Unify audio modules tests

2013-10-13 Thread Roundup Robot
Roundup Robot added the comment: New changeset ee7563b07c6f by Serhiy Storchaka in branch '3.3': Issue #18919: Unified and extended tests for audio modules: aifc, sunau and http://hg.python.org/cpython/rev/ee7563b07c6f New changeset fc418ecd8777 by Serhiy Storchaka in branch 'default': Issue #18

[issue18919] Unify audio modules tests

2013-10-13 Thread Roundup Robot
Roundup Robot added the comment: New changeset a9f967c8d002 by Serhiy Storchaka in branch '2.7': Issue #18919: Added tests for the sunau module. Unified and extended tests http://hg.python.org/cpython/rev/a9f967c8d002 -- ___ Python tracker

[issue18919] Unify audio modules tests

2013-10-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3303d735058f by Serhiy Storchaka in branch '2.7': Issue #18919: If the close() method of a writer in the sunau or wave module http://hg.python.org/cpython/rev/3303d735058f New changeset b7eae747385c by Serhiy Storchaka in branch '3.3': Issue #18919:

[issue18919] Unify audio modules tests

2013-09-29 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file31912/makeaudiotests.py ___ Python tracker ___ ___ Python-bugs-list maili

[issue18919] Unify audio modules tests

2013-09-29 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Patch updated. Now files created in external program (Audacity) are used for testing. This exposed yet one bug, in the aifc module (issue19131). -- dependencies: +Broken support of compressed AIFC files Added file: http://bugs.python.org/file31911/aud

[issue18919] Unify audio modules tests

2013-09-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Patch updated. It now contains tests for all supported encoding formats (PCM8-32, u-Law, A-Law). -- ___ Python tracker ___ __

[issue18919] Unify audio modules tests

2013-09-06 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file31632/audiotests_2.patch ___ Python tracker ___ ___ Python-bugs-list mail

[issue18919] Unify audio modules tests

2013-09-06 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- dependencies: +Miscellaneous fixes for the sunau module ___ Python tracker ___ ___ Python-bugs-list m

[issue18919] Unify audio modules tests

2013-09-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset 61ca4732399b by Serhiy Storchaka in branch 'default': Issues #18901, #18919: Fix a typo in the _sunau_params name. http://hg.python.org/cpython/rev/61ca4732399b -- nosy: +python-dev ___ Python tracker

[issue18919] Unify audio modules tests

2013-09-04 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- dependencies: +Add support of the 'with' statement to sunau.open. ___ Python tracker ___ ___ Python-b

[issue18919] Unify audio modules tests

2013-09-04 Thread Claudiu.Popa
Claudiu.Popa added the comment: I love this idea! I was thinking while working on sunau/aifc/wave patches that we can do more than this, unify the entire audio modules, getting rid of Aifc_write/read and Wave_write/read was in fact my first desire. One way that I thought about was to provide an

[issue18919] Unify audio modules tests

2013-09-04 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Three audio modules, aifc, sunau and wave, have similar interfaces and poor tests. The proposed patch introduces new file Lib/test/audiotests.py with common audio tests. New testing exposes some bugs and discrepancy between different audio modules. For ex