Changes by Charles-François Natali cf.nat...@gmail.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18934
Roundup Robot added the comment:
New changeset 0e52b9f77dbf by Charles-François Natali in branch 'default':
Issue #18934: Use poll/select-based selectors for multiprocessing.Connection,
http://hg.python.org/cpython/rev/0e52b9f77dbf
--
___
Python
Charles-François Natali added the comment:
Richard Oudkerk added the comment:
I remember wondering at one time why EPOLLNVAL did not exist, and realizing
that closed fds are just silently unregistered by epoll().
Exactly.
I guess the issue is that some of the selectors indicate a bad fd
Roundup Robot added the comment:
New changeset 14972c999e80 by Charles-François Natali in branch 'default':
Issue #18934: Relax test_multiprocessing.test_invalid_handles a bit: we just
http://hg.python.org/cpython/rev/14972c999e80
--
___
Python
Charles-François Natali added the comment:
I just realized that using DefaultSelector isn't optimal for Connection:
It's fine for forkserver, since it's a long lived process, but for
Connection.poll(), this means that it'll use epoll or kqueue: which
means allocating a new epoll/kqueue object
New submission from Charles-François Natali:
Here's a patch.
--
components: Library (Lib)
files: selectors_multiprocessing.diff
keywords: needs review, patch
messages: 197012
nosy: neologix, sbt
priority: normal
severity: normal
stage: patch review
status: open
title: multiprocessing:
Richard Oudkerk added the comment:
LGTM.
But I would move import selectors in multiprocessing.connection to just
before the definition of wait() for Unix. It is not needed on Windows and
unnecessary imports slow down start up of new processes.
--
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18934
___
___
Roundup Robot added the comment:
New changeset 81f0c6358a5f by Charles-François Natali in branch 'default':
Issue #18934: multiprocessing: use selectors module.
http://hg.python.org/cpython/rev/81f0c6358a5f
--
nosy: +python-dev
___
Python tracker
Charles-François Natali added the comment:
The test is failing on some (unstable) buildbots:
http://buildbot.python.org/all/builders/AMD64%20Solaris%2011%20%5BSB%5D%203.x/builds/1598/steps/test/logs/stdio
==
FAIL:
Richard Oudkerk added the comment:
I remember wondering at one time why EPOLLNVAL did not exist, and realizing
that closed fds are just silently unregistered by epoll().
I guess the issue is that some of the selectors indicate a bad fd on
registration, and others do it when polled.
11 matches
Mail list logo