Roundup Robot added the comment:
New changeset 1cbd3d9f7d61 by Antoine Pitrou in branch 'default':
Issue #18948: improve SuppressCoreFiles to include Windows crash popup
suppression, and use it in more tests.
http://hg.python.org/cpython/rev/1cbd3d9f7d61
--
nosy: +python-dev
Antoine Pitrou added the comment:
Patch committed. Thanks to both of you!
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18948
Zachary Ware added the comment:
Here's a patch that combines Valerie's patch with a merged suppress_crash_popup
and SuppressCoreFiles called SuppressCrashReport.
Tests ok on Windows; I haven't been able to test on Unix yet.
--
Added file:
Antoine Pitrou added the comment:
Thanks! The patch works fine here under Linux, too (though I haven't tried to
figure out if it really prevented core files from being generated).
--
___
Python tracker rep...@bugs.python.org
STINNER Victor added the comment:
Perhaps it would be best to either combine SuppressCoreFiles
and suppress_crash_popup
Yes, these two tools must be merged into one unique portable tool. Example of
names:
* ignore_fatal_errors()
* dont_report_crashes()
* ignore_crashes()
Doc: On
STINNER Victor added the comment:
test.support.SuppressCoreFiles was added by #18623.
I implemented a similar tool in my tracemalloc fork:
http://hg.python.org/features/tracemalloc/rev/b91450e51388
--
___
Python tracker rep...@bugs.python.org
Zachary Ware added the comment:
Perhaps it would be best to either combine SuppressCoreFiles and
suppress_crash_popup, or provide a new construct that does so since both are
used in almost every place one is used. Also, test_daemon_threads_fatal_error
in test_threading should be using
Valerie Lambert added the comment:
Great! Thanks for putting together a list. I've incorporated SuppressCoreFiles
into these tests and have used the test suite without any errors. Again, I'm
testing these on Ubuntu.
--
keywords: +patch
Added file:
Antoine Pitrou added the comment:
Ok, I've left a comment on the review tool above. You can click on the review
link if you haven't received an e-mail.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18948
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18948
___
___
Python-bugs-list
Valerie Lambert added the comment:
Oops! That was careless. Fixed.
--
Added file: http://bugs.python.org/file31752/issue-18948_v2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18948
New submission from Antoine Pitrou:
Here is a (exhaustive?) list of tests which deliberately crash the interpreter:
- test_daemon_threads_fatal_error() in test_threading
- several fatal error tests in test_faulthandler
- test_recursionlimit_fatalerror() in test_sys
-
12 matches
Mail list logo
