[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2015-06-29 Thread Martin Panter

Martin Panter added the comment:

inherit-doctype.v3.patch looks good to me

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2015-06-29 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 75571407dcd3 by Serhiy Storchaka in branch '3.4':
Issue #19176: Fixed doctype() related bugs in C implementation of ElementTree.
https://hg.python.org/cpython/rev/75571407dcd3

New changeset 6ae8842e9b60 by Serhiy Storchaka in branch '3.5':
Issue #19176: Fixed doctype() related bugs in C implementation of ElementTree.
https://hg.python.org/cpython/rev/6ae8842e9b60

New changeset d792dc240456 by Serhiy Storchaka in branch 'default':
Issue #19176: Fixed doctype() related bugs in C implementation of ElementTree.
https://hg.python.org/cpython/rev/d792dc240456

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2015-06-29 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

In 2.7 XMLParser is a function, not a class, and therefore can't be subclassed.

--
resolution:  - fixed
stage: commit review - resolved
status: open - closed
versions:  -Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2015-06-26 Thread Serhiy Storchaka

Changes by Serhiy Storchaka storch...@gmail.com:


--
versions: +Python 2.7, Python 3.4, Python 3.6

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2015-06-26 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Here is a patch that also fixes other issues with doctype.

1) Direct call of doctype() issues a warning.
2) Parser's doctype() is not called if target's doctype() is called.

--
Added file: http://bugs.python.org/file39820/inherit-doctype.v3.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2015-06-11 Thread Martin Panter

Martin Panter added the comment:

Ideally I guess the Python native behaviour is better: only call 
target.doctype() if available. It might allow you to easily implement doctype() 
in both the old and new versions of the API, without worrying about the API 
being called twice, and without experiencing any DeprecationWarning. But I do 
not have a real-world use case to demonstrate this, and I don’t think this 
decision should hold up committing inherit-doctype.v2.patch. They are separate 
bugs.

BTW: Another difference between the implementations is that the C version 
accepts my !DOCTYPE blaua test case, but the Python version ignores it. It 
only works with a more elaborate case like !DOCTYPE blaua SYSTEM dtd. I’m 
no expert, but I think my original XML should be allowed.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2015-06-11 Thread Martin Panter

Changes by Martin Panter vadmium...@gmail.com:


--
components: +Extension Modules

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2015-06-11 Thread Martin Panter

Changes by Martin Panter vadmium...@gmail.com:


--
components: +XML -Extension Modules

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2015-06-09 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Started topic on Python-Dev: 
http://comments.gmane.org/gmane.comp.python.devel/153655 .

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2015-05-18 Thread Eli Bendersky

Eli Bendersky added the comment:

I'm not sure. This is why I'm proposing asking on python-dev

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2015-05-18 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Then what to do with the discrepancy between Python and C implementations 
(msg238783)?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2015-05-16 Thread Eli Bendersky

Eli Bendersky added the comment:

I don't know how important this is to really warrant removal. Removal means 
potentially breaking working code when trying to run it with Python 3.5, and my 
impression was that the core devs are somewhat alergic to this, at least while 
the transition to Python 3 is ongoing.

Unless it has already been discussed (sorry if I missed it, haven't had much 
time for CPython recently, unfortunately), may be worth a quick check with 
python-dev

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2015-05-16 Thread Serhiy Storchaka

Changes by Serhiy Storchaka storch...@gmail.com:


--
assignee:  - serhiy.storchaka

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2015-05-16 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Updated to the tip. If Eli doesn't have objections, I'll commit it.

--
Added file: http://bugs.python.org/file39391/doctype-remove.v4.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2015-04-01 Thread Arfrever Frehtes Taifersar Arahesis

Arfrever Frehtes Taifersar Arahesis added the comment:

Also please apply inherit-doctype.v2.patch in 3.4 branch.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2015-03-31 Thread Martin Panter

Martin Panter added the comment:

The difference of calling XMLParser.doctype() between the implementations is 
another argument for removing it completely. With all these bugs, and no 
opposition that I know of, I think it should be okay to remove the deprecated 
doctype() method in 3.5.

doctype-remove.v2.patch adds a tweaked version of the original test for no 
DeprecationWarning from the other patch.

--
Added file: http://bugs.python.org/file38755/doctype-remove.v2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2015-03-31 Thread Martin Panter

Martin Panter added the comment:

inherit-doctype.v2.patch inverts the logic in the C module. This patch may 
still be useful if people want to apply it to 3.4, or do not want to remove the 
deprecated method from 3.5.

--
Added file: http://bugs.python.org/file38756/inherit-doctype.v2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2015-03-31 Thread Martin Panter

Martin Panter added the comment:

doctype-remove.v3.patch includes an entry on the What’s New page.

--
Added file: http://bugs.python.org/file38757/doctype-remove.v3.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2015-03-31 Thread Berker Peksag

Berker Peksag added the comment:

doctype-remove.v3.patch LGTM.

--
nosy: +berker.peksag
stage: patch review - commit review
versions:  -Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2015-03-21 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Looks as there is yet one difference in the behavior of Python and C 
implementations. In Python implementation either self.target.doctype or 
self.doctype are called. But in C implementation both are called.

--
nosy: +serhiy.storchaka
stage:  - patch review
versions:  -Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2014-12-17 Thread Martin Panter

Martin Panter added the comment:

Here is another patch that removes the method instead, as suggested in the 
review

--
Added file: http://bugs.python.org/file37490/doctype-remove.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2014-12-17 Thread Arfrever Frehtes Taifersar Arahesis

Arfrever Frehtes Taifersar Arahesis added the comment:

doctype-remove.patch is acceptable for both 3.4 and 3.5 or only 3.5?
If only 3.5, then please apply inherit-doctype.patch in 3.4.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2014-12-16 Thread Martin Panter

Martin Panter added the comment:

Since the doctype() method doesn’t appear to be removed from the “default” 
(3.5?) branch either, here is a patch that avoids the deprecation warning when 
inheriting method + a test.

Hopefully this will be useful when you get some time to look at it. I’m not 
sure if the PyCFunction_ calls are a good idea; they don’t seem to be 
documented, but I couldn’t think of a better way to check if the method was 
overridden.

--
keywords: +patch
versions: +Python 3.5
Added file: http://bugs.python.org/file37476/inherit-doctype.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2014-03-19 Thread Martin Panter

Martin Panter added the comment:

Actually I am still seeing this in 3.4.0. Looks like the doctype() method was 
not removed after all.

--
versions: +Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2013-10-31 Thread Eli Bendersky

Eli Bendersky added the comment:

Thanks for the report, Martin. I'll take a look once I get some time

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2013-10-31 Thread Arfrever Frehtes Taifersar Arahesis

Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:


--
nosy: +Arfrever

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2013-10-13 Thread Ezio Melotti

Changes by Ezio Melotti ezio.melo...@gmail.com:


--
nosy: +ezio.melotti

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2013-10-06 Thread Martin Panter

New submission from Martin Panter:

I am using the C version of Element Tree via the main ElementTree module. I 
have subclassed XMLParser, and created my own target object. I am not that 
interested in XML doctypes, but the following simplified code raises a 
DeprecationWarning:

$ python3.3 -Wall
Python 3.3.2 (default, May 16 2013, 23:40:52) 
[GCC 4.6.3] on linux
Type help, copyright, credits or license for more information.
 from xml.etree.ElementTree import XMLParser
 class CustomParser(XMLParser): pass
... 
 CustomParser().feed(!DOCTYPE blaua)
__main__:1: DeprecationWarning: This method of XMLParser is deprecated.  Define 
doctype() method on the TreeBuilder target.

Looking at the C code, the logic is wrong. Subclasses of XMLParser will 
normally always have a doctype() method, at least by inheritance. So the code 
should compare the method with the XMLParser.doctype() base method rather than 
just checking that it exists. The native Python version seems to get it right.

http://hg.python.org/cpython/file/50ea4dccb03e/Modules/_elementtree.c#l3091

It looks like this may not be an issue for Python 3.4 because according to 
Issue 13248 the deprecated doctype() method is due to be removed.

--
components: Extension Modules
messages: 199031
nosy: vadmium
priority: normal
severity: normal
status: open
title: DeprecationWarning for doctype() method when subclassing 
_elementtree.XMLParser
type: behavior
versions: Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2013-10-06 Thread Antoine Pitrou

Changes by Antoine Pitrou pit...@free.fr:


--
nosy: +eli.bendersky

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com