[issue19192] Move test_current_time from test_xmlrpc_net to test_xmlrpc

2013-10-11 Thread R. David Murray
R. David Murray added the comment: Thanks, Vajrasky. I simplified your test a bit further still. It occurs to me that nowadays (unlike when the file was written), we can use resources to skip individual test classes or even individual tests. So we could open a new issue to move the last test

[issue19192] Move test_current_time from test_xmlrpc_net to test_xmlrpc

2013-10-11 Thread Roundup Robot
Roundup Robot added the comment: New changeset a4515186bf9c by R David Murray in branch 'default': #19192: Give up on time.xmlrpc.com as an xmlrpc network test. http://hg.python.org/cpython/rev/a4515186bf9c -- nosy: +python-dev ___ Python tracker

[issue19192] Move test_current_time from test_xmlrpc_net to test_xmlrpc

2013-10-10 Thread Vajrasky Kok
Vajrasky Kok added the comment: Attached the second version patch to address R. David Murray's concerns. 1. test_dotted_attribute name has been taken, so I use test_instance_with_allow_dotted_names name. Or should I use test_instance_with_dotted_attribute name? Or maybe test_allow_dotted_names

[issue19192] Move test_current_time from test_xmlrpc_net to test_xmlrpc

2013-10-10 Thread R. David Murray
R. David Murray added the comment: Added some review comments. Summary: I think we should just make it a dotted attribute test, and forget about the 'time' thing, which was just used because that's what the available network test used. (I find it odd that allow_dotted_names does not appear t

[issue19192] Move test_current_time from test_xmlrpc_net to test_xmlrpc

2013-10-08 Thread Vajrasky Kok
New submission from Vajrasky Kok: Currently, the test_current_time is idle because the server (time.xmlrpc.com) that it requires is dead (at the moment being and no end in sight). The patch moved the test from Lib/test/test_xmlrpc_net.py to Lib/test/test_xmlrpc.py and simulate the time.xmlrpc.