Roundup Robot added the comment:
New changeset 7d914d4b05fe by Christian Heimes in branch 'default':
Issue #19448: report name / NID in exception message of ASN1Object
http://hg.python.org/cpython/rev/7d914d4b05fe
--
___
Python tracker
Christian Heimes added the comment:
Does anybody want to do a review of the patch?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19448
___
___
Antoine Pitrou added the comment:
If it's for #17134, couldn't it remain a private API?
I'm rather uncomfortable about exposing such things unless we make the ssl
module a full-fledged toolbox to handle X509 certificates (and perhaps think a
bit more about the APIs). Are there any common use
Christian Heimes added the comment:
OK, let's keep it as private API for now and maybe make it public in 3.5. I'm
going to rename ASN1Object to _ASN1Object, remove the docs and adjust the
tests. Agreed?
--
___
Python tracker rep...@bugs.python.org
Antoine Pitrou added the comment:
OK, let's keep it as private API for now and maybe make it public in
3.5. I'm going to rename ASN1Object to _ASN1Object, remove the docs
and adjust the tests. Agreed?
Yup.
--
___
Python tracker
Changes by Christian Heimes li...@cheimes.de:
--
assignee: - christian.heimes
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19448
___
___
Roundup Robot added the comment:
New changeset f43f65038e2a by Christian Heimes in branch 'default':
Issue #19448: Add private API to SSL module to lookup ASN.1 objects by OID,
NID, short name and long name.
http://hg.python.org/cpython/rev/f43f65038e2a
--
nosy: +python-dev
Christian Heimes added the comment:
Thanks!
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19448
___
Christian Heimes added the comment:
Thanks for the feed back! The new patch implements a class with two additional
class methods. The low level functions are no longer part of the public API.
--
Added file: http://bugs.python.org/file32451/ssl_asn1obj2.patch
New submission from Christian Heimes:
For #17134 I need a decent way to map OIDs to human readable strings and vice
versa. OpenSSL has a couple of method for the task, e.g.
http://www.openssl.org/docs/crypto/OBJ_nid2obj.html
The patch implements three ways to lookup NID, SN, LN and OID: by
10 matches
Mail list logo
