[issue19489] move quick search box above TOC

2016-09-09 Thread Zachary Ware
Zachary Ware added the comment: Ammar, thank you very much for the patch! -- ___ Python tracker ___ ___

[issue19489] move quick search box above TOC

2016-09-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset 8927417c5e88 by Zachary Ware in branch '3.5': Issue #19489: Add NEWS and ACKS https://hg.python.org/cpython/rev/8927417c5e88 New changeset 086c3e7a7955 by Zachary Ware in branch 'default': Issue #19489: Merge with 3.5

[issue19489] move quick search box above TOC

2016-09-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset 274b25cd501f by Zachary Ware in branch '3.5': Issue #19489: Move the search box from sidebar to header and footer. https://hg.python.org/cpython/rev/274b25cd501f New changeset 0f94a8fa5445 by Zachary Ware in branch 'default': Closes #19489: Merge

[issue19489] move quick search box above TOC

2016-09-09 Thread Ammar Askar
Ammar Askar added the comment: >The latter. All of the popular browsers (Chrome, Firefox, Edge and even >Safari) already support the placeholder attribute so I think we can safely >ignore IE 8 :) Roger, I've changed it to placeholder. >I know this is basically a copy of upstream

[issue19489] move quick search box above TOC

2016-09-03 Thread Berker Peksag
Berker Peksag added the comment: > I also found a regression in search.html. Please ignore this. It doesn't have anything to do with your patch. -- ___ Python tracker

[issue19489] move quick search box above TOC

2016-09-03 Thread Berker Peksag
Berker Peksag added the comment: > Do you mean in addition to the "Quick search" text that is already on the > page or do you want to remove that? The latter. All of the popular browsers (Chrome, Firefox, Edge and even Safari) already support the placeholder attribute so I think we can safely

[issue19489] move quick search box above TOC

2016-09-02 Thread Zachary Ware
Zachary Ware added the comment: Berker, would you mind giving this another look? If you give it the OK, I can get it committed if you don't beat me to it. -- assignee: docs@python -> berker.peksag ___ Python tracker

[issue19489] move quick search box above TOC

2016-08-24 Thread R. David Murray
R. David Murray added the comment: Moving back to patch review for someone to sign off on the changes. -- nosy: +r.david.murray stage: commit review -> patch review ___ Python tracker

[issue19489] move quick search box above TOC

2016-08-09 Thread Ammar Askar
Ammar Askar added the comment: > 1. It would be better to make "Quick search" a placeholder Do you mean in addition to the "Quick search" text that is already on the page or do you want to remove that? Because placeholder isn't fully compatible with some older browsers

[issue19489] move quick search box above TOC

2016-08-09 Thread Berker Peksag
Berker Peksag added the comment: This looks pretty good to me, thanks! I have two minor suggestions: 1. It would be better to make "Quick search" a placeholder: 2. will add an unnecessary border in search page. I'd change it to

[issue19489] move quick search box above TOC

2016-08-03 Thread Zachary Ware
Changes by Zachary Ware : -- versions: -Python 2.7 ___ Python tracker ___ ___

[issue19489] move quick search box above TOC

2016-08-03 Thread Zachary Ware
Zachary Ware added the comment: I really like the search box in the header/footer. I can't really speak for the actual content of the patch since my Sphinx/HTML/CSS/Jinja/whatever else knowledge is severely limited, but it looks pretty straightforward and the result is very nice. I'd

[issue19489] move quick search box above TOC

2016-08-03 Thread Ammar Askar
Ammar Askar added the comment: Amended the navigation bar patch to add back a change that only shows the searchbar if javascript is enabled. -- Added file: http://bugs.python.org/file43995/searchbar_in_header.diff2 ___ Python tracker

[issue19489] move quick search box above TOC

2016-08-03 Thread Ammar Askar
Ammar Askar added the comment: This patch adds the search bar to the navigation/header area on the right. -- Added file: http://bugs.python.org/file43994/searchbar_in_header.diff ___ Python tracker

[issue19489] move quick search box above TOC

2016-08-03 Thread Zachary Ware
Zachary Ware added the comment: This LGTM. If it's simple enough, I'd like to see a shot at putting the search box in the top bar, but it's not necessary :) I'll commit this in the near future unless somebody beats me to it. -- stage: needs patch -> commit review

[issue19489] move quick search box above TOC

2016-07-23 Thread Ammar Askar
Ammar Askar added the comment: Thank you for pointing that out to me, it completely slipped past. It looks like the 'Report a Bug' link disappears because deprecated api is used in Doc/tools/templates/layout.html {% block sidebarsourcelink %} {% endblock %}

[issue19489] move quick search box above TOC

2016-07-23 Thread Zachary Ware
Zachary Ware added the comment: The patch needs some work, as it stands it makes the 'Report a Bug' link disappear. I haven't looked into it far enough to determine why. For an alternative bikeshed color, would it be possible to put the quick search in the header, just left of the 'previous

[issue19489] move quick search box above TOC

2016-07-19 Thread Ammar Askar
Ammar Askar added the comment: bump, added the documentation experts list, not sure if the core dev who made this issue is still active. -- nosy: +eric.araujo ___ Python tracker

[issue19489] move quick search box above TOC

2016-07-06 Thread Ammar Askar
Ammar Askar added the comment: It looks like this can be fixed by us. Since sphinx 1.0 there is this handy config parameter: http://www.sphinx-doc.org/en/stable/config.html#confval-html_sidebars I've attached a patch which pins the searchbox as the first thing on every page. --

[issue19489] move quick search box above TOC

2016-06-05 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: Yes, I don't think we control this, the layout is generated by sphinx. -- nosy: +Jelle Zijlstra ___ Python tracker ___

[issue19489] move quick search box above TOC

2016-06-03 Thread Mark Lawrence
Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue19489] move quick search box above TOC

2016-06-02 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker ___ ___

[issue19489] move quick search box above TOC

2014-10-02 Thread Mark Lawrence
Mark Lawrence added the comment: If this is referring to the box on docs.python.org shouldn't this be logged elsewhere? -- nosy: +BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19489

[issue19489] move quick search box above TOC

2014-10-02 Thread Ezio Melotti
Changes by Ezio Melotti ezio.melo...@gmail.com: -- keywords: +easy nosy: +ezio.melotti stage: - needs patch type: - enhancement ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19489 ___

[issue19489] move quick search box above TOC

2013-11-03 Thread Georg Brandl
New submission from Georg Brandl: From Mark Summerfield:, The Quick search box is really useful, but it is annoying that its position varies from page to page. On pages with long tables of contents it is often out of sight. Why not put it above the Table of Contents. That way