Roundup Robot added the comment:
New changeset 49a2bed5185a by Zachary Ware in branch '2.7':
Issue #19493: Fix two uses of ctypes.test.requires (it's not a decorator)
http://hg.python.org/cpython/rev/49a2bed5185a
New changeset 374a9a259c09 by Zachary Ware in branch '3.4':
Issue #19493: Fix two
Roundup Robot added the comment:
New changeset 6f63fff5c120 by Zachary Ware in branch '3.4':
Issue #19493: Refactor ctypes test package.
http://hg.python.org/cpython/rev/6f63fff5c120
New changeset 86d14cf2a6a8 by Zachary Ware in branch 'default':
Issue #19493: Merge with 3.4
Roundup Robot added the comment:
New changeset 08a2b36f6287 by Zachary Ware in branch '2.7':
Issue #19493: Backport 6f63fff5c120
http://hg.python.org/cpython/rev/08a2b36f6287
--
___
Python tracker rep...@bugs.python.org
Zachary Ware added the comment:
Committed; thanks for the review, Serhiy.
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19493
Changes by Zachary Ware zachary.w...@gmail.com:
Added file: http://bugs.python.org/file33216/skip_tests_ctypes.v3.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19493
___
Zachary Ware added the comment:
Here's a new patch addressing your review comment, Serhiy. It also addresses
some failures on Windows in test_values: Win_ValuesTestCase depends on 'pydll'
being defined in the module toplevel and shadowing ctypes.pydll; this
definition was removed some years
Serhiy Storchaka added the comment:
I can't say anything about pydll, other changes LGTM. Except that I'm not sure
that test_wintypes needs a fix.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19493
Zachary Ware added the comment:
I'd prefer to keep the change to test_wintypes, simply because I was rather
surprised to find an extra test being run on Windows.
As for the pydll/pythonapi issue, any thoughts from Amaury, Meador, or
Alexander? The relevant change that removed the definition
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19493
___
___
Zachary Ware added the comment:
Here's a patch. It turned out to be much more extensive than I expected, and
the diff turned into a huge huge ugly monster that I hope Rietveld can help to
make sense of, since the majority of the diff is simply changes in indentation
level.
The most major
Zachary Ware added the comment:
Grepping with the same regexes I used for #19572 come up with some extra skips
in the ctypes tests too; would you like me to create a new patch including them
or would you like to do it, Serhiy?
--
nosy: +zach.ware
Serhiy Storchaka added the comment:
Grepping with the same regexes I used for #19572 come up with some extra
skips in the ctypes tests too; would you like me to create a new patch
including them or would you like to do it, Serhiy?
Please do this Zachary.
--
New submission from Serhiy Storchaka:
Some skipped ctypes tests are reported as passed. Proposed patch adds explicit
reporting them as skipped.
See also issue18702.
--
components: Tests, ctypes
files: skip_tests_ctypes.patch
keywords: patch
messages: 202124
nosy: amaury.forgeotdarc,
13 matches
Mail list logo
