Roundup Robot added the comment:
New changeset 039ac3f01c4e by Victor Stinner in branch '2.7':
Issue #19612: subprocess.communicate() now also ignores EINVAL when using at
http://hg.python.org/cpython/rev/039ac3f01c4e
--
___
Python tracker
STINNER Victor added the comment:
I didnd't see the failure recently on Windows, so I close the issue.
I backported the fix on Python 2.7 for the issue #21946.
--
resolution: - fixed
status: open - closed
versions: +Python 2.7
___
Python tracker
STINNER Victor added the comment:
Oh, it looks like my patch is not enough: the test still fails sometimes :-/ It
looks like the process was still running (poll() didn't return None) whereas
stdin.write() got an OSError(errno.EINVAL).
STINNER Victor added the comment:
If I add a sleep of 1 second before stdin.write(), the test always fail with
OSError(22, Invalid parameter). So it becomes obvious that the write fails if
the process already exited.
Attached patch should fix the issue. Can someone review it?
The test fails
Guido van Rossum added the comment:
LGTM. Please commit in both repos and add to the list of cherrypicks for
Larry.
On Tue, Feb 18, 2014 at 1:40 AM, STINNER Victor rep...@bugs.python.orgwrote:
STINNER Victor added the comment:
If I add a sleep of 1 second before stdin.write(), the test
Roundup Robot added the comment:
New changeset 83013a7be836 by Victor Stinner in branch '3.3':
Issue #19612: On Windows, subprocess.Popen.communicate() now ignores
http://hg.python.org/cpython/rev/83013a7be836
New changeset 423cb79640eb by Victor Stinner in branch 'default':
(Merge 3.3) Issue
STINNER Victor added the comment:
LGTM.
Thanks for the review.
Please commit in both repos and add to the list of cherrypicks for
Larry.
Both repos? You mean Tulip? This issue is specific to subprocess not asyncio
(asyncio.subprocess).
This sporadic bug is not new. IMO it exists since
Guido van Rossum added the comment:
Sorry, forget everything I said. (That includes the LGTM, sadly -- as I wrote
earlier I don't know this code very well.)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19612
STINNER Victor added the comment:
Sorry, forget everything I said. (That includes the LGTM, sadly -- as I wrote
earlier I don't know this code very well.)
Don't worry, I'm confident in my change :)
--
___
Python tracker rep...@bugs.python.org
Changes by STINNER Victor victor.stin...@gmail.com:
--
title: test_subprocess: sporadic failure of test_communicate_epipe() -
test_subprocess: sporadic failure of test_communicate_epipe() on Windows 8
___
Python tracker rep...@bugs.python.org
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +gvanrossum, neologix, pitrou, tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19612
___
Guido van Rossum added the comment:
I don't know much about subprocess.py and I don't have access to Windows 8.
But it looks like the kind of thing that might happen if the other end of the
pipe is closed, which might happen if the subprocess exits early, either
because it's just fast or
12 matches
Mail list logo
