Sworddragon added the comment:
I'm wondering what the recursion limit is if -l and -r are not given. Does it
default to 10 too or is there no limit? If the first is the case maybe this
should also get documented.
--
___
Python tracker
Benjamin Peterson added the comment:
Why can't we just reuse the -l option?
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19628
___
Claudiu Popa added the comment:
Backward compatibility reasons, I guess. compileall -l completely deactivates
the recursion, so using -l for controlling the number of levels seems to
overwrite its original meaning.
--
___
Python tracker
Roundup Robot added the comment:
New changeset a62368778d6c by Benjamin Peterson in branch 'default':
allow recursion depth to be specified (closes #19628)
http://hg.python.org/cpython/rev/a62368778d6c
--
nosy: +python-dev
resolution: - fixed
stage: commit review - resolved
status:
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +berker.peksag
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19628
___
___
Changes by Claudiu Popa pcmantic...@gmail.com:
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19628
___
___
R. David Murray added the comment:
Do we really want to allow infinite recursion (say a symbolic link loop)?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19628
___
R. David Murray added the comment:
Ah, bad font, I thought the -l was a -1. I see you aren't adding the infinite
recursion, the just ability to control the maximum. The patch looks good to me.
--
stage: patch review - commit review
___
Python
Changes by Claudiu Popa pcmantic...@gmail.com:
--
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19628
___
___
Claudiu.Popa added the comment:
Added patch which addresses the comments of Berker Peksag. Thanks for the
review!
--
Added file: http://bugs.python.org/file34786/issue19628_1.patch
___
Python tracker rep...@bugs.python.org
Claudiu.Popa added the comment:
Ping. :) Can someone review this patch, please?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19628
___
___
Changes by Claudiu.Popa pcmantic...@gmail.com:
--
versions: +Python 3.5 -Python 3.4
Added file: http://bugs.python.org/file34360/issue19628.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19628
Claudiu.Popa added the comment:
Here's a patch which adds support for controlling the maxlevels on command
line. Currently, compileall uses a binary choice, either we don't process
subdirectories or we process at most 10 subdirectories. This seems to be the
case since its inception, in
Changes by Claudiu.Popa pcmantic...@gmail.com:
--
versions: +Python 3.4 -Python 2.7, Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19628
___
New submission from Sworddragon:
All functions of compileall are providing a maxlevels argument which defaults
to 10. But it is currently not possible to disable this recursion limitation.
Maybe it would be useful to have a special value like -1 to disable this
limitation and allow to compile
15 matches
Mail list logo
