[issue19633] test_wave: failures on PPC64 buildbot
Roundup Robot added the comment: New changeset 7b040bc289e8 by Serhiy Storchaka in branch '3.3': Issue #19633: Fixed writing not compressed 16- and 32-bit wave files on http://hg.python.org/cpython/rev/7b040bc289e8 New changeset 7cf7f19445ba by Serhiy Storchaka in branch 'default': Issue #19633: Fixed writing not compressed 16- and 32-bit wave files on http://hg.python.org/cpython/rev/7cf7f19445ba New changeset 03a32ead9c7d by Serhiy Storchaka in branch '2.7': Issue #19633: Fixed writing not compressed 16- and 32-bit wave files on http://hg.python.org/cpython/rev/03a32ead9c7d -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19633 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19633] test_wave: failures on PPC64 buildbot
STINNER Victor added the comment: PPC64 PowerLinux 3.x buildbot is green again! I'm closing the issue. I didn't check 2.7 and 3.3 buildbots. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19633 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19633] test_wave: failures on PPC64 buildbot
David Edelsohn added the comment: By the way, test_wave also fails on zLinux, which also is Big Endian. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19633 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19633] test_wave: failures on PPC64 buildbot
Serhiy Storchaka added the comment:
array's constructor interprets its second memoryview argument as an iterable of
integers.
import array
array.array('h', b'abcd')
array('h', [25185, 25699])
array.array('h', memoryview(b'abcd'))
array('h', [97, 98, 99, 100])
array.frombytes() always interpret its argument as bytes-like object.
a = array.array('h')
a.frombytes(memoryview(b'abcd'))
a
array('h', [25185, 25699])
First patch fixes only a half of the issue. test_unseekable_incompleted_write()
still failed because array.fromfile() fails read incomplete data. Second patch
also adds unittest.expectedFailure decorators for these tests.
--
Added file: http://bugs.python.org/file32680/wave_byteswap_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19633
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19633] test_wave: failures on PPC64 buildbot
STINNER Victor added the comment: array's constructor interprets its second memoryview argument as an iterable of integers. Ok so, so your fix is correct. First patch fixes only a half of the issue. test_unseekable_incompleted_write() still failed because array.fromfile() fails read incomplete data. Why the test succeeded on little endian? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19633 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19633] test_wave: failures on PPC64 buildbot
Serhiy Storchaka added the comment: Why the test succeeded on little endian? Because array.fromfile() is used only to swap 16- and 32-bit samples on bigendian platform. Perhaps we need the byteswap() function in the audioop module. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19633 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19633] test_wave: failures on PPC64 buildbot
STINNER Victor added the comment: Because array.fromfile() is used only to swap 16- and 32-bit samples on bigendian platform. If the file is truncated, why would the test suceed on little endian? The file doesn't have the same size in bytes? The test doesn't check the number of frames? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19633 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19633] test_wave: failures on PPC64 buildbot
Serhiy Storchaka added the comment: If the file is truncated, why would the test suceed on little endian? The file doesn't have the same size in bytes? The test doesn't check the number of frames? Because this code is not used on little endian. On little endian a data is read by file's read() method. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19633 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19633] test_wave: failures on PPC64 buildbot
New submission from STINNER Victor: Some test_wave are failing, but only on PPC64 (big endian, right?). It may be related to issue #1575020. http://buildbot.python.org/all/builders/PPC64%20PowerLinux%203.x/builds/1099/steps/test/logs/stdio == ERROR: test_unseekable_incompleted_write (test.test_wave.WavePCM16Test) -- Traceback (most recent call last): File /home/shager/cpython-buildarea/3.x.edelsohn-powerlinux-ppc64/build/Lib/test/audiotests.py, line 243, in test_unseekable_incompleted_write self.check_file(testfile, self.nframes + 1, self.frames) File /home/shager/cpython-buildarea/3.x.edelsohn-powerlinux-ppc64/build/Lib/test/audiotests.py, line 84, in check_file self.assertEqual(f.readframes(nframes), frames) File /home/shager/cpython-buildarea/3.x.edelsohn-powerlinux-ppc64/build/Lib/wave.py, line 257, in readframes data.fromfile(chunk.file.file, nitems) EOFError: read() didn't return enough bytes == ERROR: test_unseekable_incompleted_write (test.test_wave.WavePCM32Test) -- Traceback (most recent call last): File /home/shager/cpython-buildarea/3.x.edelsohn-powerlinux-ppc64/build/Lib/test/audiotests.py, line 243, in test_unseekable_incompleted_write self.check_file(testfile, self.nframes + 1, self.frames) File /home/shager/cpython-buildarea/3.x.edelsohn-powerlinux-ppc64/build/Lib/test/audiotests.py, line 84, in check_file self.assertEqual(f.readframes(nframes), frames) File /home/shager/cpython-buildarea/3.x.edelsohn-powerlinux-ppc64/build/Lib/wave.py, line 257, in readframes data.fromfile(chunk.file.file, nitems) EOFError: read() didn't return enough bytes == FAIL: test_write_array (test.test_wave.WavePCM16Test) -- Traceback (most recent call last): File /home/shager/cpython-buildarea/3.x.edelsohn-powerlinux-ppc64/build/Lib/test/audiotests.py, line 163, in test_write_array self.check_file(TESTFN, self.nframes, self.frames) File /home/shager/cpython-buildarea/3.x.edelsohn-powerlinux-ppc64/build/Lib/test/audiotests.py, line 83, in check_file self.assertEqual(f.getnframes(), nframes) AssertionError: 96 != 48 == FAIL: test_write_memoryview (test.test_wave.WavePCM16Test) -- Traceback (most recent call last): File /home/shager/cpython-buildarea/3.x.edelsohn-powerlinux-ppc64/build/Lib/test/audiotests.py, line 171, in test_write_memoryview self.check_file(TESTFN, self.nframes, self.frames) File /home/shager/cpython-buildarea/3.x.edelsohn-powerlinux-ppc64/build/Lib/test/audiotests.py, line 83, in check_file self.assertEqual(f.getnframes(), nframes) AssertionError: 96 != 48 == FAIL: test_write_array (test.test_wave.WavePCM32Test) -- Traceback (most recent call last): File /home/shager/cpython-buildarea/3.x.edelsohn-powerlinux-ppc64/build/Lib/test/audiotests.py, line 163, in test_write_array self.check_file(TESTFN, self.nframes, self.frames) File /home/shager/cpython-buildarea/3.x.edelsohn-powerlinux-ppc64/build/Lib/test/audiotests.py, line 83, in check_file self.assertEqual(f.getnframes(), nframes) AssertionError: 192 != 48 == FAIL: test_write_memoryview (test.test_wave.WavePCM32Test) -- Traceback (most recent call last): File /home/shager/cpython-buildarea/3.x.edelsohn-powerlinux-ppc64/build/Lib/test/audiotests.py, line 171, in test_write_memoryview self.check_file(TESTFN, self.nframes, self.frames) File /home/shager/cpython-buildarea/3.x.edelsohn-powerlinux-ppc64/build/Lib/test/audiotests.py, line 83, in check_file self.assertEqual(f.getnframes(), nframes) AssertionError: 192 != 48 -- components: Tests messages: 203217 nosy: haypo, serhiy.storchaka priority: normal severity: normal status: open title: test_wave: failures on PPC64 buildbot versions: Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19633 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19633] test_wave: failures on PPC64 buildbot
Serhiy Storchaka added the comment: Thank you for your report. This patch should fix the issue. -- components: +Library (Lib) -Tests keywords: +patch stage: - patch review type: - behavior Added file: http://bugs.python.org/file32674/wave_byteswap.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19633 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19633] test_wave: failures on PPC64 buildbot
Changes by David Edelsohn dje@gmail.com: -- nosy: +David.Edelsohn ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19633 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
