[issue19687] Fixes for elementtree integer overflow

[Roundup Robot]

Roundup Robot added the comment:

New changeset e5eac1d692ad by Serhiy Storchaka in branch '3.4':
Issue #19687: Fixed possible integer overflows in ElementTree.
https://hg.python.org/cpython/rev/e5eac1d692ad

New changeset 745fd5550bc0 by Serhiy Storchaka in branch '2.7':
Issue #19687: Fixed possible integer overflows in ElementTree.
https://hg.python.org/cpython/rev/745fd5550bc0

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19687] Fixes for elementtree integer overflow

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Possible integer overflows in 3.5 was already fixed by issue23450.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19687] Fixes for elementtree integer overflow

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Christian's patch fixes two things: integer overflow and memory leak. First 
I'll commit a fix for memory leak (with cleanup and tests). Integer overflow 
looks already fixed in recent releases, there is nothing to commit. This part 
should be applied only to old releases.

--
assignee:  -> serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19687] Fixes for elementtree integer overflow

[Roundup Robot]

Roundup Robot added the comment:

New changeset d51d420f3e9d by Serhiy Storchaka in branch '3.4':
Issue #19687: Fixed memory leak on failed Element slice assignment.
https://hg.python.org/cpython/rev/d51d420f3e9d

New changeset 4d5417444961 by Serhiy Storchaka in branch '3.5':
Issue #19687: Fixed memory leak on failed Element slice assignment.
https://hg.python.org/cpython/rev/4d5417444961

New changeset de5a11836ad4 by Serhiy Storchaka in branch 'default':
Issue #19687: Fixed memory leak on failed Element slice assignment.
https://hg.python.org/cpython/rev/de5a11836ad4

New changeset c33e4881721f by Serhiy Storchaka in branch '2.7':
Issue #19687: Fixed memory leak on failed Element slice assignment.
https://hg.python.org/cpython/rev/c33e4881721f

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19687] Fixes for elementtree integer overflow

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Here is updated patch for 3.4.

Added new overflow checks in element_resize(), some runtime checks are replaced 
with asserts (conditions are always true), check for buffer size is copied from 
3.5, followed Eli's suggestions about nchildren and index.

--
Added file: http://bugs.python.org/file41123/elementtree_overflow3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19687] Fixes for elementtree integer overflow

[Eli Bendersky]

Eli Bendersky added the comment:

Serhiy, I'm truly sorry but for this and other issues you pinged -- I currently 
have zero bandwidth to invest in this. Feel free to ask around on pydev if 
there are other folks interested in reviewing patches and decisions w.r.t the 
etree module. I'm fine with your judgement otherwise.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19687] Fixes for elementtree integer overflow

[Serhiy Storchaka]

Changes by Serhiy Storchaka storch...@gmail.com:


--
nosy:  -serhiy.storchaka

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19687
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19687] Fixes for elementtree integer overflow

[Eli Bendersky]

Eli Bendersky added the comment:

Thanks. I left some comments in the code review tool

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19687
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19687] Fixes for elementtree integer overflow

[Christian Heimes]

Christian Heimes added the comment:

New patch with fixes for element_ass_subscr().

--
Added file: http://bugs.python.org/file32971/elementtree_overflow2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19687
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19687] Fixes for elementtree integer overflow

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

See also *first* patch in issue16986.

--
nosy: +eli.bendersky, scoder, serhiy.storchaka

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19687
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19687] Fixes for elementtree integer overflow

[Christian Heimes]

New submission from Christian Heimes:

The patch addresses most overflow errors in elementtree except for the problems 
in element_ass_subscr().

--
components: Library (Lib)
files: elementtree_overflow.patch
keywords: patch
messages: 203702
nosy: christian.heimes, haypo
priority: normal
severity: normal
stage: patch review
status: open
title: Fixes for elementtree integer overflow
type: compile error
versions: Python 3.4
Added file: http://bugs.python.org/file32767/elementtree_overflow.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19687
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com