[issue19711] add test for changed portions after reloading a namespace package

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue19711] add test for changed portions after reloading a namespace package

Changes by Eric Snow : -- versions: +Python 3.6 -Python 3.5 ___ Python tracker ___

[issue19711] add test for changed portions after reloading a namespace package

Eric Snow added the comment: I've gone ahead and pushed the patch. -- resolution: -> fixed stage: test needed -> resolved status: open -> closed ___ Python tracker

[issue19711] add test for changed portions after reloading a namespace package

Roundup Robot added the comment: New changeset c22ec7a45114 by Eric Snow in branch 'default': Fixes #19711: Add tests for reloading namespace packages. https://hg.python.org/cpython/rev/c22ec7a45114 -- nosy: +python-dev ___ Python tracker

[issue19711] add test for changed portions after reloading a namespace package

Mark Lawrence added the comment: To echo Brett's question, do we still need this patch, Eric? -- status: pending - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19711 ___

[issue19711] add test for changed portions after reloading a namespace package

Brett Cannon added the comment: Do we still need this patch, Eric? -- status: open - pending versions: +Python 3.5 -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19711 ___

[issue19711] add test for changed portions after reloading a namespace package

Mark Lawrence added the comment: Latest patch LGTM. Can we have a patch review please as #18864 is dependent on this. -- nosy: +BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19711

[issue19711] add test for changed portions after reloading a namespace package

Eric Snow added the comment: Well, the same patch (modulo adjusting to apply cleanly) fails in exactly the same way in 3.3. So either the test isn't right or namespace packages have never supported reload in this way. I'll keep investigating. --

[issue19711] add test for changed portions after reloading a namespace package

Eric Snow added the comment: Regarding this issue, keep in mind that namespace packages have a dynamic __path__ which already updates (effectively) when new portions are added to sys.path. So we just need to make sure that reloading does not break that. To that end, here's a much simpler

[issue19711] add test for changed portions after reloading a namespace package

Changes by Eric Snow ericsnowcurren...@gmail.com: -- assignee: - eric.snow ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19711 ___ ___

[issue19711] add test for changed portions after reloading a namespace package

Eric Snow added the comment: A related addition (Lib/test/test_importlib/test_api.py - test_reload_namespace_changed): changeset: 86819:88c3a1a3c2ff3c3ab3f2bd77f0d5d5e5c1b37afa parent: 86816:13a05ed33cf7 user:Eric Snow ericsnowcurren...@gmail.com date:Thu Oct 31 22:22:15

[issue19711] add test for changed portions after reloading a namespace package

Eric Snow added the comment: Here's a patch that adds the test. However, the test is failing and my gut's telling me it's a legitimate failure. I'll verify as soon as I have a chance and open a new issue if it is legit (i.e. a regression in 3.4, albeit an unlikely corner case). Thanks for

[issue19711] add test for changed portions after reloading a namespace package

Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19711 ___

[issue19711] add test for changed portions after reloading a namespace package

New submission from Brett Cannon: http://bugs.python.org/msg202660 -- components: Tests messages: 203805 nosy: brett.cannon, eric.snow, ncoghlan priority: normal severity: normal stage: test needed status: open title: add test for changed portions after reloading a namespace package