Roundup Robot added the comment:
New changeset a21ddb1c41d2 by Brett Cannon in branch 'default':
Issue #19714: Tests for importlib.machinery.WindowsRegistryFinder.
http://hg.python.org/cpython/rev/a21ddb1c41d2
--
nosy: +python-dev
___
Python tracker
Brett Cannon added the comment:
Thanks for the patch, Claudiu. Sorry it took so long to apply, but you know
what I have been working on instead so I'm sure you understand. =)
--
resolution: - fixed
status: open - closed
___
Python tracker
Changes by Berker Peksag berker.pek...@gmail.com:
--
stage: commit review - resolved
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19714
___
___
Changes by Brett Cannon br...@python.org:
--
assignee: - brett.cannon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19714
___
___
Martin v. Löwis added the comment:
The patch looks fine to me. Someone please apply.
--
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19714
___
Brett Cannon added the comment:
I can do the review if no Windows people step forward.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19714
___
Mark Lawrence added the comment:
Latest patch LGTM at a quick glance. Can we have a patch review please as
#18864 is dependent on this.
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19714
Changes by Claudiu Popa pcmantic...@gmail.com:
--
stage: test needed - patch review
versions: +Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19714
___
Claudiu Popa added the comment:
Attached a new version of the patch. The previous one called find_spec twice in
the same test.
--
Added file: http://bugs.python.org/file35651/issue19714_2.patch
___
Python tracker rep...@bugs.python.org
Jim Jewett added the comment:
Pinging Martin ... earlier comments seem to have been completed.
--
nosy: +Jim.Jewett
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19714
___
Eric Snow added the comment:
Martin: are you okay with Claudiu's latest patch?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19714
___
___
Changes by Claudiu.Popa pcmantic...@gmail.com:
Added file: http://bugs.python.org/file34570/issue19714.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19714
___
Claudiu.Popa added the comment:
Hello. Here's a patch for this issue. It tests only the conditions described by
Eric.
--
keywords: +patch
nosy: +Claudiu.Popa
Added file: http://bugs.python.org/file34549/issue19714.patch
___
Python tracker
Changes by Claudiu.Popa pcmantic...@gmail.com:
Added file: http://bugs.python.org/file34553/issue19714.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19714
___
Eric Snow added the comment:
I added 2 rudimentary tests for issue #20097 which gives at least coverage in
the test suite, but we need the following tests still:
* registry entry exists and module is found (spec returned)
* registry entry exists and module is not found (None returned)
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +vajrasky
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19714
___
___
Python-bugs-list mailing
Changes by Eric Snow ericsnowcurren...@gmail.com:
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19714
___
___
Python-bugs-list
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19714
___
New submission from Brett Cannon:
At least mocking out things if manipulating the Windows registry during testing
is considered bad or difficult to make sure that stuff basically works.
--
components: Library (Lib)
messages: 203809
nosy: brett.cannon
priority: normal
severity: normal
Changes by Brett Cannon br...@python.org:
--
nosy: +eric.snow, ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19714
___
___
20 matches
Mail list logo
