[issue19737] Documentation of globals() and locals() should be improved

Łukasz Langa added the comment: Thanks! ✨  ✨ -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue19737] Documentation of globals() and locals() should be improved

Łukasz Langa added the comment: New changeset 9299e3a39c3b1dd7d5db0d88080249c2dab3070f by Miss Islington (bot) in branch '3.9': bpo-19737: Improved the documentation for globals (GH-29823) (GH-30042) https://github.com/python/cpython/commit/9299e3a39c3b1dd7d5db0d88080249c2dab3070f

[issue19737] Documentation of globals() and locals() should be improved

Łukasz Langa added the comment: New changeset 1f7000808e8385e2a29ffd0ef6aac9a6139d3d92 by Miss Islington (bot) in branch '3.10': bpo-19737: Improved the documentation for globals (GH-29823) (GH-30041) https://github.com/python/cpython/commit/1f7000808e8385e2a29ffd0ef6aac9a6139d3d92

[issue19737] Documentation of globals() and locals() should be improved

Change by miss-islington : -- pull_requests: +28268 pull_request: https://github.com/python/cpython/pull/30042 ___ Python tracker ___

[issue19737] Documentation of globals() and locals() should be improved

Change by miss-islington : -- nosy: +miss-islington nosy_count: 7.0 -> 8.0 pull_requests: +28267 pull_request: https://github.com/python/cpython/pull/30041 ___ Python tracker

[issue19737] Documentation of globals() and locals() should be improved

Łukasz Langa added the comment: New changeset 4fe5585240f64c3d14eb635ff82b163f92074b3a by 180909 in branch 'main': bpo-19737: Improved the documentation for globals (GH-29823) https://github.com/python/cpython/commit/4fe5585240f64c3d14eb635ff82b163f92074b3a -- nosy: +lukasz.langa

[issue19737] Documentation of globals() and locals() should be improved

Change by jiahua wang : -- nosy: +180909 nosy_count: 5.0 -> 6.0 pull_requests: +28055 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29823 ___ Python tracker

[issue19737] Documentation of globals() and locals() should be improved

Change by Irit Katriel : -- keywords: +easy versions: +Python 3.10, Python 3.11, Python 3.9 -Python 2.7, Python 3.4, Python 3.5 ___ Python tracker ___

[issue19737] Documentation of globals() and locals() should be improved

Martin Panter added the comment: Terry’s “dictionary implementing the namespace” version would work for me. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19737 ___

[issue19737] Documentation of globals() and locals() should be improved

Terry J. Reedy added the comment: My succinct version: Return the dictionary implementing the current module namespace. For code within functions, this is set when the function is defined and remains the same regardless of where a function is called. -- versions: +Python 3.5 -Python

[issue19737] Documentation of globals() and locals() should be improved

Martin Panter added the comment: Here is a patch with my suggestion. It also now refers to _the_ dictionary rather than just _a_ dictionary, and drops the word “current”, so that it does not sound like saving a snapshot. -- keywords: +patch Added file:

[issue19737] Documentation of globals() and locals() should be improved

Changes by Martin Panter vadmium...@gmail.com: Removed file: http://bugs.python.org/file37478/globals-copy.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19737 ___

[issue19737] Documentation of globals() and locals() should be improved

Changes by Martin Panter vadmium...@gmail.com: Added file: http://bugs.python.org/file37479/globals-copy.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19737 ___

[issue19737] Documentation of globals() and locals() should be improved

Terry J. Reedy added the comment: In my opinion, vague ideas like this one should go to python-ideas first. I agree with David that globals() and locals() are separate issues. Since there have been and perhaps still are locals() doc issues, I will take this one to be about 'globals()'. A

[issue19737] Documentation of globals() and locals() should be improved

Martin Panter added the comment: How about swapping the two sentences for globals() then: “Returns the dictionary of the module . . . This represents the symbol table . . .” I thought the current locals() entry is fairly clear. It actually says _not_ to modify the dictionary! --

[issue19737] Documentation of globals() and locals() should be improved

New submission from Zahari Dim: The globals() notification states: Return a dictionary representing the current global symbol table.[...] This doc and the fact that globals() is called as a function made me think that globals() returns a copy of the global namespace dict, rather than an

[issue19737] Documentation of globals() and locals() should be improved

R. David Murray added the comment: We've tried improving the locals docs several times. Modifying it is not safe, in the sense that what happens when you do is not defined by the language. Which locals docs were you looking at? I agree that 'representing' is not as clear as would be optimal

[issue19737] Documentation of globals() and locals() should be improved

Zahari Dim added the comment: I am looking at the docs of the built-in functions: http://docs.python.org/2/library/functions.html -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19737 ___

[issue19737] Documentation of globals() and locals() should be improved

Changes by Martin Panter vadmium...@gmail.com: -- nosy: +vadmium ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19737 ___ ___ Python-bugs-list