[issue19791] test_pathlib should use can_symlink or skip_unless_symlink from test.support

2017-03-28 Thread Brett Cannon
Changes by Brett Cannon : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ P

[issue19791] test_pathlib should use can_symlink or skip_unless_symlink from test.support

2017-03-28 Thread Brett Cannon
Brett Cannon added the comment: New changeset ec1f5df46ed37aa3e839d20298c4b361a9a74bc4 by Brett Cannon (Vajrasky Kok) in branch 'master': bpo-19791: Use functions from test support to check the symlink support. (GH-822) https://github.com/python/cpython/commit/ec1f5df46ed37aa3e839d20298c4b361a

[issue19791] test_pathlib should use can_symlink or skip_unless_symlink from test.support

2017-03-26 Thread ppperry
Changes by ppperry : -- pull_requests: +729 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue19791] test_pathlib should use can_symlink or skip_unless_symlink from test.support

2017-03-26 Thread Vajrasky Kok
Vajrasky Kok added the comment: Okay, this is the pull request: https://github.com/python/cpython/pull/822 -- ___ Python tracker ___ _

[issue19791] test_pathlib should use can_symlink or skip_unless_symlink from test.support

2017-03-26 Thread Vajrasky Kok
Vajrasky Kok added the comment: Okay, Serhiy. I'll create a pull request. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue19791] test_pathlib should use can_symlink or skip_unless_symlink from test.support

2017-03-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Can you create a pull request on GitHub Vajrasky? -- nosy: +serhiy.storchaka ___ Python tracker ___ __

[issue19791] test_pathlib should use can_symlink or skip_unless_symlink from test.support

2016-04-16 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag stage: -> patch review type: behavior -> enhancement versions: +Python 3.6 -Python 3.5 ___ Python tracker ___

[issue19791] test_pathlib should use can_symlink or skip_unless_symlink from test.support

2013-11-26 Thread Vajrasky Kok
Vajrasky Kok added the comment: > How about we defer this to Python 3.5, to make merging easier ? Sure. -- versions: +Python 3.5 -Python 3.4 ___ Python tracker ___ _

[issue19791] test_pathlib should use can_symlink or skip_unless_symlink from test.support

2013-11-26 Thread Antoine Pitrou
Antoine Pitrou added the comment: Mmh... The reason it's like that is that pathlib is originally 2.7-compatible (and I'd like to do a 1.0 release on PyPI by the Python 3.4 timeframe). How about we defer this to Python 3.5, to make merging easier ? -- __

[issue19791] test_pathlib should use can_symlink or skip_unless_symlink from test.support

2013-11-25 Thread Vajrasky Kok
New submission from Vajrasky Kok: Right now, Lib/test/test_pathlib.py uses custom checking symbolic link function. But in test.support, we have those functions already (can_symlink and skip_unless_symlink). The only feature that test.support checking symbolic link functions don't have is getti