[issue19791] test_pathlib should use can_symlink or skip_unless_symlink from test.support

[Brett Cannon]

Changes by Brett Cannon :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19791] test_pathlib should use can_symlink or skip_unless_symlink from test.support

[Brett Cannon]

Brett Cannon added the comment:


New changeset ec1f5df46ed37aa3e839d20298c4b361a9a74bc4 by Brett Cannon 
(Vajrasky Kok) in branch 'master':
bpo-19791: Use functions from test support to check the symlink support. 
(GH-822)
https://github.com/python/cpython/commit/ec1f5df46ed37aa3e839d20298c4b361a9a74bc4


--
nosy: +brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19791] test_pathlib should use can_symlink or skip_unless_symlink from test.support

[ppperry]

Changes by ppperry :


--
pull_requests: +729

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19791] test_pathlib should use can_symlink or skip_unless_symlink from test.support

[Vajrasky Kok]

Vajrasky Kok added the comment:

Okay, this is the pull request: https://github.com/python/cpython/pull/822

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19791] test_pathlib should use can_symlink or skip_unless_symlink from test.support

[Vajrasky Kok]

Vajrasky Kok added the comment:

Okay, Serhiy. I'll create a pull request.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19791] test_pathlib should use can_symlink or skip_unless_symlink from test.support

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Can you create a pull request on GitHub Vajrasky?

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19791] test_pathlib should use can_symlink or skip_unless_symlink from test.support

[Berker Peksag]

Changes by Berker Peksag :


--
nosy: +berker.peksag
stage:  -> patch review
type: behavior -> enhancement
versions: +Python 3.6 -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19791] test_pathlib should use can_symlink or skip_unless_symlink from test.support

[Antoine Pitrou]

Antoine Pitrou added the comment:

Mmh... The reason it's like that is that pathlib is originally 2.7-compatible 
(and I'd like to do a 1.0 release on PyPI by the Python 3.4 timeframe). How 
about we defer this to Python 3.5, to make merging easier ?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19791
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19791] test_pathlib should use can_symlink or skip_unless_symlink from test.support

[Vajrasky Kok]

Vajrasky Kok added the comment:

 How about we defer this to Python 3.5, to make merging easier ?

Sure.

--
versions: +Python 3.5 -Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19791
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19791] test_pathlib should use can_symlink or skip_unless_symlink from test.support

[Vajrasky Kok]

New submission from Vajrasky Kok:

Right now, Lib/test/test_pathlib.py uses custom checking symbolic link 
function. But in test.support, we have those functions already (can_symlink and 
skip_unless_symlink). The only feature that test.support checking symbolic link 
functions don't have is getting the reason why we don't have symbolic link 
support. But we can create a separate ticket to add that feature in 
test.support.

Attached the patch to use can_symlink and skip_unless_symlink. It also removed 
unnecessary import.

--
components: Tests
files: use_can_symlink_from_test_support.patch
keywords: patch
messages: 204456
nosy: pitrou, vajrasky
priority: normal
severity: normal
status: open
title: test_pathlib should use can_symlink or skip_unless_symlink from 
test.support
type: behavior
versions: Python 3.4
Added file: 
http://bugs.python.org/file32850/use_can_symlink_from_test_support.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19791
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com