[issue20002] Cleanup and microoptimize pathlib

[Ram Rachum]

Ram Rachum  added the comment:

Antoine: Serhiy linked me to this issue when I opened #40753 . Do you think 
that this patch by Serhiy could now be merged?

--
nosy: +cool-RR

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20002] Cleanup and microoptimize pathlib

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

If you are not interested in any of proposed changes Antoine, this issue can be 
closed.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20002
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20002] Cleanup and microoptimize pathlib

[Serhiy Storchaka]

Changes by Serhiy Storchaka storch...@gmail.com:


--
status: open - pending

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20002
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20002] Cleanup and microoptimize pathlib

[Antoine Pitrou]

Antoine Pitrou added the comment:

Not really, sorry.

--
status: pending - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20002
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20002] Cleanup and microoptimize pathlib

[Serhiy Storchaka]

Changes by Serhiy Storchaka storch...@gmail.com:


--
resolution:  - rejected
stage: patch review - resolved

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20002
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20002] Cleanup and microoptimize pathlib

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

Here is a patch which contains many small cleanups and optimizations for the 
pathlib module. Not all of them can be backported to 2.7 version.

--
assignee: pitrou
components: Library (Lib)
files: pathlib_cleanup.patch
keywords: patch
messages: 206357
nosy: pitrou, serhiy.storchaka
priority: normal
severity: normal
stage: patch review
status: open
title: Cleanup and microoptimize pathlib
type: enhancement
versions: Python 3.4
Added file: http://bugs.python.org/file33167/pathlib_cleanup.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20002
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20002] Cleanup and microoptimize pathlib

[Antoine Pitrou]

Antoine Pitrou added the comment:

Ok, since it makes backporting more tedious, I'd rather keep this for post-3.4.

--
versions: +Python 3.5 -Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20002
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20002] Cleanup and microoptimize pathlib

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Here is compatible with 2.7 part of the patch. It is important to apply it 
before 3.4 release otherwise supporting different versions will be more tedious.

--
Added file: http://bugs.python.org/file33170/pathlib_cleanup_compatible.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20002
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20002] Cleanup and microoptimize pathlib

[Antoine Pitrou]

Antoine Pitrou added the comment:

 Here is compatible with 2.7 part of the patch. It is important to
 apply it before 3.4 release otherwise supporting different versions
 will be more tedious.

Do you have performance numbers that show a significant improvement?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20002
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20002] Cleanup and microoptimize pathlib

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

 Do you have performance numbers that show a significant improvement?

No. The benefit is too small (but theoretically it should be). Some changes 
also simplify the code. This is why this patch should be applied now, while 
pathlib code is not frozen yet.

For example drv or root replaced by root or drv because drv is always 
false on Unix and both arguments of or should be evaluated. This is very 
tiny optimization, but it has zero cos if apply it right now.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20002
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com